Skip to content

Conversation

geniusjoe
Copy link
Contributor

Purpose of the change

Since we deleted shared and key-shared subscription type in pulsar source connector, I think it is better to remove these subscription type in isEnableAutoAcknowledgeMessage option comment to prevent misunderstanding.

Brief change log

update SourceConfiguration.java isEnableAutoAcknowledgeMessage comment.

Significant changes

  • Dependencies have been added or upgraded
  • Public API has been changed (Public API is any class annotated with @Public(Evolving))
  • Serializers have been changed
  • New feature has been introduced

Copy link

boring-cyborg bot commented May 28, 2024

Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)

@geniusjoe geniusjoe changed the title [FLINK-35468][Connectors/Pulsar] update isEnableAutoAcknowledgeMessage config comment [FLINK-35468] Update isEnableAutoAcknowledgeMessage config comment May 28, 2024
@syhily
Copy link
Contributor

syhily commented Jun 5, 2024

Shared subscription won't be introduced to Connector anymore. We will only use the Exclusive subscription because the Flink can handle the fallover logic internally. So the comments can be simplified.

@geniusjoe
Copy link
Contributor Author

Shared subscription won't be introduced to Connector anymore. We will only use the Exclusive subscription because the Flink can handle the fallover logic internally. So the comments can be simplified.

Thanks for your reply. Would you mind merge this pr?

@ferenc-csaky ferenc-csaky merged commit eb67b4c into apache:main Oct 21, 2025
Copy link

boring-cyborg bot commented Oct 21, 2025

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants