[FLINK-35477] Make initial cursor position configurable #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) |
|
In Pull Request #103, only the |
thomasg19930417
changed the title
thomasg19930417
changed the title
ferenc-csaky
approved these changes
Oct 17, 2025
| } | ||
| } | ||
|
|
||
| if (Objects.equals(startCursor, StartCursor.latest())) { |
There was a problem hiding this comment.
nit: StartCursor.latest().equals(startCursor) is also null-safe, shorter and does not require a util class
| .enumType(SubscriptionInitialPosition.class) | ||
| .defaultValue(SubscriptionInitialPosition.Latest) | ||
| .withDescription( | ||
| Description.builder().text("Consumer initial position.").build()); |
There was a problem hiding this comment.
I would add a bit more descriptive text here, e.g.: Initial cursor position of the consumer.
ferenc-csaky
changed the title
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the change
For example: Add dynamic sink topic support for Pulsar connector.
Brief change log
ProducerRegister.PulsarSinkContext.MetadataListener.Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality
guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Significant changes
(Please check any boxes [x] if the answer is "yes". You can first publish the PR and check them afterwards, for
convenience.)
@Public(Evolving))