FINERACT-2354: Validation of Re-age amount during submission #5183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alberto-art3ch
force-pushed
the
FINERACT-2354/validation-of-re-age-amount-during-submission
branch
4 times, most recently
from
b72208d to
2bd9427
Compare
alberto-art3ch
force-pushed
the
FINERACT-2354/validation-of-re-age-amount-during-submission
branch
from
2bd9427 to
1c15211
Compare
Contributor
|
@alberto-art3ch Please rebase |
adamsaghy
reviewed
Dec 1, 2025
| this.resourceId = resourceId; | ||
| this.commandId = null; | ||
| this.jsonCommand = null; | ||
| this.jsonCommand = parsedCommand.toString(); |
Contributor
There was a problem hiding this comment.
I am not sure this is correct.
adamsaghy
reviewed
Dec 1, 2025
| if (command.parameterExists(LoanReAgingApiConstants.transactionAmountParamName)) { | ||
| final BigDecimal transactionAmount = command | ||
| .bigDecimalValueOfParameterNamed(LoanReAgingApiConstants.transactionAmountParamName); | ||
| final BigDecimal totalReAgeAmount = totalPrincipalOutstanding.add(loan.getSummary().getTotalInterestOutstanding()); |
Contributor
There was a problem hiding this comment.
I dont think this is correct. We should move this validation out from this and make the check after the correct "reage" amount was calculated by Fineract. After we have this information we can do the check and throw error if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a Scenario where the total outstanding amount could change during the time the re-age is previewed and applied.
Example
When the re-age preview is called, the total outstanding of the loan was $250, and a repayment was made before the re-age was applied, which had reduced the total outstanding of the loan to $200. which is an edge case.
In this case, the system should not allow the re-age to be applied for $250
FINERACT-2354
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.