FINERACT-2181: Any amount payment after reage loan is overpaid #5136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alberto-art3ch
force-pushed
the
FINERACT-2181/reage-pay-off-or-any-amount-payment-loan-is-overpaid
branch
2 times, most recently
from
47012f4 to
f8724d8
Compare
peter-kovacs-dpc
suggested changes
Nov 3, 2025
| | Name | isPenalty | Payment due at | Due as of | Calculation type | Due | Paid | Waived | Outstanding | | ||
| | Snooze fee | false | Specified due date | 15 May 2024 | Flat | 10.0 | 0.0 | 0.0 | 10.0 | | ||
|
|
||
| @TestRailId:C4092 @AdvancedPaymentAllocation |
Contributor
There was a problem hiding this comment.
pl change @TestrailId:C4157
I added it to Testrail (4092 is already used)
alberto-art3ch
force-pushed
the
FINERACT-2181/reage-pay-off-or-any-amount-payment-loan-is-overpaid
branch
from
f8724d8 to
892833d
Compare
peter-kovacs-dpc
approved these changes
Nov 3, 2025
adamsaghy
reviewed
Nov 4, 2025
| @@ -112,6 +110,9 @@ public CommandProcessingResult reAge(Long loanId, JsonCommand command) { | |||
| loanTransactions.add(reAgeTransaction); | |||
| reprocessLoanTransactionsService.reprocessParticularTransactions(loan, loanTransactions); | |||
| } else { | |||
| final LoanRepaymentScheduleTransactionProcessor loanRepaymentScheduleTransactionProcessor = loanRepaymentScheduleTransactionProcessorFactory | |||
Contributor
There was a problem hiding this comment.
I dont get how this could be fixing anything...
adamsaghy
requested changes
Nov 4, 2025
Contributor
adamsaghy
left a comment
adamsaghy
left a comment
There was a problem hiding this comment.
Kindly share more information why moving the processor determination fix anything here...
alberto-art3ch
force-pushed
the
FINERACT-2181/reage-pay-off-or-any-amount-payment-loan-is-overpaid
branch
from
892833d to
8baf0e3
Compare
Contributor
|
@alberto-art3ch Please rebase the branch, resolve the conflicts, and take a look at the failing test cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Loan after pay-off or any amount payment loan is overpaid with 1st repayment amount before re-age, mainly in this case:
in case loan paid-off - status is closed outstanding amount is 0, in case any repayment amount less that paid -off amount - status is active with correct outstanding amount
FINERACT-2181
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.