FINERACT-2354: Re-age - Excess payment handling - Default Behavior, interestRecalculation = true #5122
+1,859
−728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariiaKraievska
force-pushed
the
FINERACT-2354/reaging-default-behaviour-interest-bearing-loan-partially-paid-last-installment-edge-case
branch
2 times, most recently
from
bb14437 to
4d1ba4f
Compare
mariiaKraievska
force-pushed
the
FINERACT-2354/reaging-default-behaviour-interest-bearing-loan-partially-paid-last-installment-edge-case
branch
2 times, most recently
from
43cc49d to
f1939f8
Compare
adamsaghy
reviewed
Nov 17, 2025
| && DateUtils.isBefore(currentBusinessDate, expectedMaturityDate); | ||
| if (installment.isDownPayment()) { | ||
| isCurrentDateBeforeInstallmentAndLoanPeriod = DateUtils.isEqual(currentBusinessDate, installment.getDueDate()) | ||
| if (!installment.isPaidMovedPaidDuringReAging()) { |
Contributor
There was a problem hiding this comment.
isPaidMovedPaidDuringReAging -> duplicate usage of the word of "paid"?
adamsaghy
reviewed
Nov 17, 2025
| && DateUtils.isBefore(currentBusinessDate, expectedMaturityDate); | ||
| if (installment.isDownPayment()) { | ||
| isCurrentDateBeforeInstallmentAndLoanPeriod = DateUtils.isEqual(currentBusinessDate, installment.getDueDate()) | ||
| if (!installment.isPaidMovedPaidDuringReAging()) { |
Contributor
There was a problem hiding this comment.
Why do we need to modify this logic?
Contributor
Author
There was a problem hiding this comment.
I wanted just to exclude reAgePaidInstallment here
adamsaghy
reviewed
Nov 17, 2025
| private boolean isReAged; | ||
|
|
||
| @Column(name = "is_paid_moved_during_re_aging", nullable = false) | ||
| private boolean isPaidMovedPaidDuringReAging; |
Contributor
There was a problem hiding this comment.
Can it be something more generic, like "isReageSpecialInstallment" or "isReagePaidInstallment"? isPaidMovedPaidDuringReAging sounds weird to me.
adamsaghy
reviewed
Nov 17, 2025
|
|
||
| loanTransaction.updateComponentsAndTotal(totalOutstandingPrincipal, interestFromZeroedInstallments, Money.zero(currency), | ||
| Money.zero(currency)); | ||
| reprocessInstallments(installments); |
Contributor
Author
There was a problem hiding this comment.
I returned it back, but modified the sorting
adamsaghy
reviewed
Nov 17, 2025
|
|
||
| @Getter | ||
| @Setter | ||
| private boolean isPeriodWithMovedPaidAmountDuringReAging = false; |
Contributor
There was a problem hiding this comment.
Can we use something similar like in the repayment installment entity which describe the nature of the period instead of the action?
mariiaKraievska
force-pushed
the
FINERACT-2354/reaging-default-behaviour-interest-bearing-loan-partially-paid-last-installment-edge-case
branch
from
f1939f8 to
4e7ac7d
Compare
mariiaKraievska
changed the title
mariiaKraievska
force-pushed
the
FINERACT-2354/reaging-default-behaviour-interest-bearing-loan-partially-paid-last-installment-edge-case
branch
4 times, most recently
from
5d2fe4b to
8b6945c
Compare
mariiaKraievska
force-pushed
the
FINERACT-2354/reaging-default-behaviour-interest-bearing-loan-partially-paid-last-installment-edge-case
branch
3 times, most recently
from
ec57729 to
88c44f4
Compare
mariiaKraievska
changed the title
…nterestRecalculation = true
…t to last edge case of re-aging
…nterestRecalculation = true, without dueDate change - missing testRailIds added
mariiaKraievska
force-pushed
the
FINERACT-2354/reaging-default-behaviour-interest-bearing-loan-partially-paid-last-installment-edge-case
branch
from
88c44f4 to
7c82a41
Compare
adamsaghy
deleted the
FINERACT-2354/reaging-default-behaviour-interest-bearing-loan-partially-paid-last-installment-edge-case
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.