Skip to content

Conversation

@GGBOUNDBOY
Copy link

@GGBOUNDBOY GGBOUNDBOY commented Oct 16, 2025

Purpose of the pull request

What's changed?

Checklist

  • I have read the Contributor Guide.
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

@delei
Copy link
Member

delei commented Oct 16, 2025

Hi, @GGBOUNDBOY

Thank you for submitting this PR.

FYI, we do need to support internationalization. I feel the current implementation proposal seems overly simplified. We need to discuss solutions in issue #57 , such as supporting Locale and MessageSource.

Without further improvements or optimized implementation solutions, it is recommended not to merge this PR yet.

@delei delei added pending This problem needs to be confirmed PR: require-multiple-approvals This pull request requires multiple approvals. labels Oct 16, 2025
@GGBOUNDBOY
Copy link
Author

Hi, @GGBOUNDBOY

Thank you for submitting this PR.

FYI, we do need to support internationalization. I feel the current implementation proposal seems overly simplified. We need to discuss solutions in issue #57 , such as supporting Locale and MessageSource.

Without further improvements or optimized implementation solutions, it is recommended not to merge this PR yet.
使用函数控制表头转换比使用多语言的方式是不是更加容易扩展,因为无法确认使用者最终是使用那种方式来实现多语言的,可能使用者有自己的一套实现的方式,并不是基于spring boot的。使用者只要实现相应的方法,按项目的实际情况来扩展表头转换即可。

@delei
Copy link
Member

delei commented Oct 17, 2025

Currently, using a custom handler to modify the headers seems to also be applicable. We hope to receive more suggestions from the community to further simplify the development and facilitate expansion.

@alaahong
Copy link
Member

First of all, we should pass all in CI
image

@GGBOUNDBOY GGBOUNDBOY closed this Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pending This problem needs to be confirmed PR: require-multiple-approvals This pull request requires multiple approvals.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants