Skip to content

Conversation

alaahong
Copy link
Member

Purpose of the pull request

Related: #101 #332
Still confuse on the verification

What's changed?

java9 folder for JDK 9+ compile

Checklist

  • I have read the Contributor Guide.
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for the Java Platform Module System (JPMS) to Apache Fesod, enabling the library to be used as a named module in Java 9+ environments while maintaining Java 8 compatibility.

  • Adds JPMS module descriptor (module-info.java) with appropriate exports and dependencies
  • Implements comprehensive module tests to verify module functionality and consumer usage
  • Updates build configuration to compile module descriptor only on JDK 9+
  • Refactors test utilities to work properly in modular environments

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
fesod/src/main/java9/module-info.java Defines the JPMS module with exports and dependencies
fesod/pom.xml Adds Java 9+ profile for module compilation and testing
fesod/src/test/java9/org/apache/fesod/excel/module/*.java Module-specific tests for verification
fesod/src/test/java/org/apache/fesod/excel/util/TestFileUtil.java Refactored for module path compatibility
website/**.md Documentation updates for module maintenance

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@alaahong
Copy link
Member Author

Close by might not the time to push this. More discussion welcome.

@alaahong alaahong closed this Oct 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant