Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: An instance of the subclass of RegistryConfig should be added to configsCache as the RegistryConfig class type #15016 #15017

Open
wants to merge 1 commit into
base: 3.3
Choose a base branch
from

Conversation

youjie23
Copy link

What is the purpose of the change?

Fix #15016
An instance of the subclass of RegistryConfig should be added to configsCache as the RegistryConfig class type

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

… to configsCache as the RegistryConfig class type(apache#15016)
@codecov-commenter
Copy link

codecov-commenter commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.76%. Comparing base (a9e4910) to head (6ac903a).

Files with missing lines Patch % Lines
...he/dubbo/config/context/AbstractConfigManager.java 85.71% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                3.3   #15017      +/-   ##
============================================
- Coverage     60.76%   60.76%   -0.01%     
- Complexity    10866    10873       +7     
============================================
  Files          1882     1882              
  Lines         85983    85985       +2     
  Branches      12876    12876              
============================================
+ Hits          52246    52247       +1     
- Misses        28289    28291       +2     
+ Partials       5448     5447       -1     
Flag Coverage Δ
integration-tests 33.03% <57.14%> (-0.11%) ⬇️
samples-tests 29.09% <57.14%> (-0.14%) ⬇️
unit-tests 58.91% <85.71%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants