Support Multi-region Kafka ingests #18036
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtuglu-netflix
force-pushed
the
multi-region-kafka-ingest-support
branch
from
5ae6ec1 to
5d8f93a
Compare
jtuglu-netflix
force-pushed
the
multi-region-kafka-ingest-support
branch
from
5d8f93a to
cfb7363
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
|
|
||
| @Override | ||
| protected RecordSupplier<KafkaTopicPartition, Long, KafkaRecordEntity> setupRecordSupplier() | ||
| { | ||
| final KafkaSupervisorIOConfig ioConfig = spec.getIoConfig(); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
jtuglu-netflix
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #18008
TODO: add design info
Description
Creates a RecordSupplierGroup which can mux calls across multiple
RecordSupplierinstances. Currently keeping it so every indexing task is only reading from a single consumer (not multiple) as it is simplest (and no noisy neighbor), but this is liable to change especially with scaling. The only place where thispoll()is called against multiple consumers in parallel is during data sampling in the data loader UI.Release note
Key changed/added classes in this PR
MyFooOurBarTheirBazThis PR has: