[bugfix](memory) should count memory when cancel query is called #58252

yiguolei · 2025-11-22T02:46:20Z

*** Current BE git commitID: 4945aa0 ***
*** SIGABRT unknown detail explain (@0x3c54) received by PID 15444 (TID 16396 OR 0x7b2e9f39b700) from PID 15444; stack trace: ***
0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*) at /root/doris/be/src/common/signal_handler.h:420
1# 0x00007F3421D1D420 in /lib/x86_64-linux-gnu/libpthread.so.0
2# raise at ../sysdeps/unix/sysv/linux/raise.c:51
3# abort at /build/glibc-SzIz7B/glibc-2.31/stdlib/abort.c:81
4# 0x000055A425A57985 in /home/work/unlimit_teamcity/TeamCity/Agents/20251120181904agent_172.16.0.6_1/work/60183217f6ee2a9c/output/be/lib/doris_be
5# 0x000055A425A4923A in /home/work/unlimit_teamcity/TeamCity/Agents/20251120181904agent_172.16.0.6_1/work/60183217f6ee2a9c/output/be/lib/doris_be
6# google::LogMessage::SendToLog() in /home/work/unlimit_teamcity/TeamCity/Agents/20251120181904agent_172.16.0.6_1/work/60183217f6ee2a9c/output/be/lib/doris_be
7# google::LogMessage::Flush() in /home/work/unlimit_teamcity/TeamCity/Agents/20251120181904agent_172.16.0.6_1/work/60183217f6ee2a9c/output/be/lib/doris_be
8# google::LogMessageFatal::~LogMessageFatal() in /home/work/unlimit_teamcity/TeamCity/Agents/20251120181904agent_172.16.0.6_1/work/60183217f6ee2a9c/output/be/lib/doris_be
9# doris::Status doris::Status::FatalError<true, std::__cxx11::basic_string<char, std::char_traits, std::allocator >&>(std::basic_string_view<char, std::char_traits >, std::__cxx11::basic_string<char, std::char_traits, std::allocator >&) at /root/doris/be/src/common/status.h:467
10# doris::io::LocalFileReader::read_at_impl(unsigned long, doris::Slice, unsigned long*, doris::io::IOContext const*) at /root/doris/be/src/io/fs/local_file_reader.cpp:151
11# doris::io::FileReader::read_at(unsigned long, doris::Slice, unsigned long*, doris::io::IOContext const*) at /root/doris/be/src/io/fs/file_reader.cpp:34
12# doris::io::S3FileSystem::upload_impl(std::filesystem::__cxx11::path const&, std::filesystem::__cxx11::path const&) at /root/doris/be/src/io/fs/s3_file_system.cpp:339
13# doris::io::RemoteFileSystem::upload(std::filesystem::__cxx11::path const&, std::filesystem::__cxx11::path const&) at /root/doris/be/src/io/fs/remote_file_system.cpp:34
14# doris::RuntimeState::get_error_log_file_pathabi:cxx11 at /root/doris/be/src/runtime/runtime_state.cpp:418
15# doris::pipeline::PipelineFragmentContext::get_load_error_urlabi:cxx11 at /root/doris/be/src/pipeline/pipeline_fragment_context.cpp:1806
16# doris::pipeline::PipelineFragmentContext::cancel(doris::Status) at /root/doris/be/src/pipeline/pipeline_fragment_context.cpp:202
17# doris::QueryContext::cancel_all_pipeline_context(doris::Status const&, int) in /home/work/unlimit_teamcity/TeamCity/Agents/20251120181904agent_172.16.0.6_1/work/60183217f6ee2a9c/output/be/lib/doris_be
18# doris::QueryContext::cancel(doris::Status, int) in /home/work/unlimit_teamcity/TeamCity/Agents/20251120181904agent_172.16.0.6_1/work/60183217f6ee2a9c/output/be/lib/doris_be
19# doris::FragmentMgr::cancel_query(doris::TUniqueId, doris::Status) at /root/doris/be/src/runtime/fragment_mgr.cpp:915
20# std::_Function_handler<void (), doris::PInternalService::cancel_plan_fragment(google::protobuf::RpcController*, doris::PCancelPlanFragmentRequest const*, doris::PCancelPlanFragmentResult*, google::protobuf::Closure*)::$_0>::_M_invoke(std::_Any_data const&) at /usr/local/ldb-toolchain-v0.26/bin/../lib/gcc/x86_64-pc-linux-gnu/15/include/g++-v15/bits/std_function.h:292
21# doris::WorkThreadPool::work_thread(int) in /home/work/unlimit_teamcity/TeamCity/Agents/20251120181904agent_172.16.0.6_1/work/60183217f6ee2a9c/output/be/lib/doris_be
22# execute_native_thread_routine in /home/work/unlimit_teamcity/TeamCity/Agents/20251120181904agent_172.16.0.6_1/work/60183217f6ee2a9c/output/be/lib/doris_be
23# asan_thread_start(void*) in /home/work/unlimit_teamcity/TeamCity/Agents/20251120181904agent_172.16.0.6_1/work/60183217f6ee2a9c/output/be/lib/doris_be

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

hello-stephen · 2025-11-22T02:46:25Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

yiguolei · 2025-11-22T03:04:24Z

run buildall

doris-robot · 2025-11-22T04:49:47Z

TPC-H: Total hot run time: 34711 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 58b63b7b8a475c229a4336ebeb0d63f6b8efdd2a, data reload: false

------ Round 1 ----------------------------------
q1	18240	5165	4960	4960
q2	2034	318	219	219
q3	10264	1291	759	759
q4	10237	962	393	393
q5	7505	2436	2372	2372
q6	184	164	136	136
q7	923	764	636	636
q8	9335	1362	1111	1111
q9	7315	5406	5359	5359
q10	6914	2209	1814	1814
q11	503	309	283	283
q12	357	365	232	232
q13	17787	3665	3041	3041
q14	227	237	223	223
q15	594	496	501	496
q16	1037	996	938	938
q17	597	897	375	375
q18	7952	7288	7220	7220
q19	1091	967	556	556
q20	346	339	224	224
q21	3893	3291	2370	2370
q22	1072	1044	994	994
Total cold run time: 108407 ms
Total hot run time: 34711 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5145	5018	4966	4966
q2	315	392	310	310
q3	2169	2682	2307	2307
q4	1398	1782	1340	1340
q5	4339	4530	4564	4530
q6	228	181	132	132
q7	2075	2042	1804	1804
q8	2688	2630	2612	2612
q9	7741	7474	7649	7474
q10	3035	3312	3121	3121
q11	611	533	507	507
q12	672	756	589	589
q13	3655	3953	3289	3289
q14	293	302	268	268
q15	553	515	495	495
q16	1064	1092	1054	1054
q17	1189	1562	1440	1440
q18	7877	7583	7489	7489
q19	831	800	873	800
q20	1922	1993	1834	1834
q21	4706	4317	4346	4317
q22	1059	1040	1012	1012
Total cold run time: 53565 ms
Total hot run time: 51690 ms

doris-robot · 2025-11-22T05:01:26Z

TPC-DS: Total hot run time: 187724 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 58b63b7b8a475c229a4336ebeb0d63f6b8efdd2a, data reload: false

query1	1037	409	406	406
query2	6569	1689	1680	1680
query3	6760	225	228	225
query4	26435	23061	22610	22610
query5	4372	625	466	466
query6	331	237	219	219
query7	4661	495	295	295
query8	293	254	243	243
query9	8691	2580	2580	2580
query10	499	334	302	302
query11	15781	15052	14747	14747
query12	170	119	110	110
query13	1670	568	458	458
query14	10453	9320	9415	9320
query15	204	191	169	169
query16	7286	676	557	557
query17	1267	791	648	648
query18	2000	436	329	329
query19	221	220	183	183
query20	131	135	125	125
query21	222	139	115	115
query22	4270	4474	4223	4223
query23	33811	32843	32989	32843
query24	8574	2401	2486	2401
query25	630	570	446	446
query26	1230	268	160	160
query27	2758	500	366	366
query28	4392	2197	2181	2181
query29	816	616	487	487
query30	291	226	195	195
query31	900	828	717	717
query32	84	76	75	75
query33	590	373	324	324
query34	796	859	519	519
query35	798	839	734	734
query36	951	974	920	920
query37	114	108	93	93
query38	3489	3503	3437	3437
query39	1461	1413	1412	1412
query40	223	135	117	117
query41	65	62	62	62
query42	120	111	110	110
query43	495	498	465	465
query44	1250	769	779	769
query45	185	190	179	179
query46	883	987	658	658
query47	1726	1763	1722	1722
query48	392	434	341	341
query49	816	494	401	401
query50	648	674	421	421
query51	3813	3932	3894	3894
query52	113	108	96	96
query53	256	266	198	198
query54	318	283	292	283
query55	92	88	80	80
query56	351	320	310	310
query57	1223	1196	1097	1097
query58	290	292	265	265
query59	2521	2617	2667	2617
query60	330	345	327	327
query61	166	164	159	159
query62	789	739	660	660
query63	227	196	197	196
query64	4532	1198	895	895
query65	4018	3985	3969	3969
query66	1167	429	328	328
query67	15686	15231	15073	15073
query68	6829	944	635	635
query69	505	329	280	280
query70	1233	1262	1247	1247
query71	416	341	322	322
query72	5942	5075	5198	5075
query73	644	561	362	362
query74	8818	9084	8999	8999
query75	3306	3343	2816	2816
query76	3291	1118	750	750
query77	506	401	348	348
query78	9631	9669	8873	8873
query79	2698	832	618	618
query80	699	552	504	504
query81	512	261	223	223
query82	334	159	138	138
query83	258	271	250	250
query84	250	116	98	98
query85	993	496	473	473
query86	380	314	309	309
query87	3715	3693	3554	3554
query88	3799	2205	2221	2205
query89	388	346	294	294
query90	1885	222	211	211
query91	165	171	142	142
query92	91	70	64	64
query93	2433	1017	670	670
query94	725	446	322	322
query95	414	326	319	319
query96	482	576	276	276
query97	2909	3014	2864	2864
query98	252	214	203	203
query99	1340	1415	1268	1268
Total cold run time: 273546 ms
Total hot run time: 187724 ms

doris-robot · 2025-11-22T05:06:32Z

ClickBench: Total hot run time: 27.33 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 58b63b7b8a475c229a4336ebeb0d63f6b8efdd2a, data reload: false

query1	0.06	0.05	0.05
query2	0.09	0.04	0.05
query3	0.25	0.09	0.08
query4	1.61	0.11	0.11
query5	0.28	0.25	0.25
query6	1.16	0.65	0.64
query7	0.04	0.03	0.02
query8	0.05	0.04	0.05
query9	0.59	0.53	0.53
query10	0.58	0.56	0.56
query11	0.16	0.10	0.10
query12	0.15	0.11	0.12
query13	0.62	0.60	0.60
query14	1.00	0.98	1.00
query15	0.85	0.84	0.83
query16	0.39	0.39	0.38
query17	1.01	1.04	1.04
query18	0.21	0.19	0.20
query19	1.89	1.80	1.80
query20	0.02	0.01	0.01
query21	15.43	0.19	0.13
query22	5.09	0.07	0.05
query23	15.65	0.26	0.10
query24	3.38	0.66	0.47
query25	0.08	0.05	0.06
query26	0.13	0.14	0.12
query27	0.06	0.05	0.06
query28	4.35	1.14	0.93
query29	12.63	3.97	3.23
query30	0.28	0.13	0.11
query31	2.82	0.61	0.38
query32	3.23	0.56	0.48
query33	3.05	3.02	3.13
query34	15.77	5.18	4.49
query35	4.62	4.55	4.55
query36	0.67	0.50	0.48
query37	0.09	0.07	0.06
query38	0.06	0.03	0.04
query39	0.04	0.02	0.02
query40	0.17	0.14	0.13
query41	0.09	0.03	0.03
query42	0.04	0.03	0.03
query43	0.04	0.03	0.03
Total cold run time: 98.78 s
Total hot run time: 27.33 s

github-actions · 2025-11-22T09:37:37Z

PR approved by anyone and no changes requested.

github-actions · 2025-11-22T09:54:23Z

PR approved by at least one committer and no changes requested.

hello-stephen · 2025-11-22T10:41:02Z

BE UT Coverage Report

Increment line coverage 92.86% (13/14) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	52.64% (18281/34731)
Line Coverage	38.08% (166346/436851)
Region Coverage	33.02% (129316/391594)
Branch Coverage	33.82% (55500/164091)

hello-stephen · 2025-11-22T10:46:28Z

BE Regression && UT Coverage Report

Increment line coverage 100.00% (14/14) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	71.52% (24381/34092)
Line Coverage	57.99% (253431/437017)
Region Coverage	53.32% (211611/396902)
Branch Coverage	54.67% (90257/165102)

) *** Current BE git commitID: 4945aa0 *** *** SIGABRT unknown detail explain (@0x3c54) received by PID 15444 (TID 16396 OR 0x7b2e9f39b700) from PID 15444; stack trace: *** 0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*) at /root/doris/be/src/common/signal_handler.h:420 1# 0x00007F3421D1D420 in /lib/x86_64-linux-gnu/libpthread.so.0 2# raise at ../sysdeps/unix/sysv/linux/raise.c:51 3# abort at /build/glibc-SzIz7B/glibc-2.31/stdlib/abort.c:81 4# 0x000055A425A57985 in /home/work/unlimit_teamcity/TeamCity/Agents/20251120181904agent_172.16.0.6_1/work/60183217f6ee2a9c/output/be/lib/doris_be 5# 0x000055A425A4923A in /home/work/unlimit_teamcity/TeamCity/Agents/20251120181904agent_172.16.0.6_1/work/60183217f6ee2a9c/output/be/lib/doris_be 6# google::LogMessage::SendToLog() in /home/work/unlimit_teamcity/TeamCity/Agents/20251120181904agent_172.16.0.6_1/work/60183217f6ee2a9c/output/be/lib/doris_be 7# google::LogMessage::Flush() in /home/work/unlimit_teamcity/TeamCity/Agents/20251120181904agent_172.16.0.6_1/work/60183217f6ee2a9c/output/be/lib/doris_be 8# google::LogMessageFatal::~LogMessageFatal() in /home/work/unlimit_teamcity/TeamCity/Agents/20251120181904agent_172.16.0.6_1/work/60183217f6ee2a9c/output/be/lib/doris_be 9# doris::Status doris::Status::FatalError<true, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&>(std::basic_string_view<char, std::char_traits<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&) at /root/doris/be/src/common/status.h:467 10# doris::io::LocalFileReader::read_at_impl(unsigned long, doris::Slice, unsigned long*, doris::io::IOContext const*) at /root/doris/be/src/io/fs/local_file_reader.cpp:151 11# doris::io::FileReader::read_at(unsigned long, doris::Slice, unsigned long*, doris::io::IOContext const*) at /root/doris/be/src/io/fs/file_reader.cpp:34 12# doris::io::S3FileSystem::upload_impl(std::filesystem::__cxx11::path const&, std::filesystem::__cxx11::path const&) at /root/doris/be/src/io/fs/s3_file_system.cpp:339 13# doris::io::RemoteFileSystem::upload(std::filesystem::__cxx11::path const&, std::filesystem::__cxx11::path const&) at /root/doris/be/src/io/fs/remote_file_system.cpp:34 14# doris::RuntimeState::get_error_log_file_path[abi:cxx11]() at /root/doris/be/src/runtime/runtime_state.cpp:418 15# doris::pipeline::PipelineFragmentContext::get_load_error_url[abi:cxx11]() at /root/doris/be/src/pipeline/pipeline_fragment_context.cpp:1806 16# doris::pipeline::PipelineFragmentContext::cancel(doris::Status) at /root/doris/be/src/pipeline/pipeline_fragment_context.cpp:202 17# doris::QueryContext::cancel_all_pipeline_context(doris::Status const&, int) in /home/work/unlimit_teamcity/TeamCity/Agents/20251120181904agent_172.16.0.6_1/work/60183217f6ee2a9c/output/be/lib/doris_be 18# doris::QueryContext::cancel(doris::Status, int) in /home/work/unlimit_teamcity/TeamCity/Agents/20251120181904agent_172.16.0.6_1/work/60183217f6ee2a9c/output/be/lib/doris_be 19# doris::FragmentMgr::cancel_query(doris::TUniqueId, doris::Status) at /root/doris/be/src/runtime/fragment_mgr.cpp:915 20# std::_Function_handler<void (), doris::PInternalService::cancel_plan_fragment(google::protobuf::RpcController*, doris::PCancelPlanFragmentRequest const*, doris::PCancelPlanFragmentResult*, google::protobuf::Closure*)::$_0>::_M_invoke(std::_Any_data const&) at /usr/local/ldb-toolchain-v0.26/bin/../lib/gcc/x86_64-pc-linux-gnu/15/include/g++-v15/bits/std_function.h:292 21# doris::WorkThreadPool<false>::work_thread(int) in /home/work/unlimit_teamcity/TeamCity/Agents/20251120181904agent_172.16.0.6_1/work/60183217f6ee2a9c/output/be/lib/doris_be 22# execute_native_thread_routine in /home/work/unlimit_teamcity/TeamCity/Agents/20251120181904agent_172.16.0.6_1/work/60183217f6ee2a9c/output/be/lib/doris_be 23# asan_thread_start(void*) in /home/work/unlimit_teamcity/TeamCity/Agents/20251120181904agent_172.16.0.6_1/work/60183217f6ee2a9c/output/be/lib/doris_be ### Release note None ### Check List (For Author) - Test  - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason  - Behavior changed: - [ ] No. - [ ] Yes.  - Does this need documentation? - [ ] No. - [ ] Yes.  ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label

[bugfix](memory) should count memory when cancel query is called

377d45c

yiguolei added the dev/4.0.x label Nov 22, 2025

f

58b63b7

zhiqiang-hhhh approved these changes Nov 22, 2025

View reviewed changes

github-actions bot added the reviewed label Nov 22, 2025

zclllyybb approved these changes Nov 22, 2025

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 22, 2025

yiguolei merged commit ada3074 into apache:master Nov 22, 2025
27 of 28 checks passed

github-actions bot mentioned this pull request Nov 22, 2025

branch-4.0: [bugfix](memory) should count memory when cancel query is called #58252 #58256

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[bugfix](memory) should count memory when cancel query is called #58252

[bugfix](memory) should count memory when cancel query is called #58252

Uh oh!

yiguolei commented Nov 22, 2025

Uh oh!

hello-stephen commented Nov 22, 2025

Uh oh!

yiguolei commented Nov 22, 2025

Uh oh!

doris-robot commented Nov 22, 2025

Uh oh!

doris-robot commented Nov 22, 2025

Uh oh!

doris-robot commented Nov 22, 2025

Uh oh!

github-actions bot commented Nov 22, 2025

Uh oh!

github-actions bot commented Nov 22, 2025

Uh oh!

hello-stephen commented Nov 22, 2025

Uh oh!

hello-stephen commented Nov 22, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

[bugfix](memory) should count memory when cancel query is called #58252

[bugfix](memory) should count memory when cancel query is called #58252

Uh oh!

Conversation

yiguolei commented Nov 22, 2025

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

hello-stephen commented Nov 22, 2025

Uh oh!

yiguolei commented Nov 22, 2025

Uh oh!

doris-robot commented Nov 22, 2025

Uh oh!

doris-robot commented Nov 22, 2025

Uh oh!

doris-robot commented Nov 22, 2025

Uh oh!

github-actions bot commented Nov 22, 2025

Uh oh!

github-actions bot commented Nov 22, 2025

Uh oh!

hello-stephen commented Nov 22, 2025

BE UT Coverage Report

Uh oh!

hello-stephen commented Nov 22, 2025

BE Regression && UT Coverage Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants