-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[feat](snapshot) fix AdminCreateClusterSnapshotCommand #58119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat](snapshot) fix AdminCreateClusterSnapshotCommand #58119
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
FE UT Coverage ReportIncrement line coverage |
TPC-H: Total hot run time: 34232 ms |
TPC-DS: Total hot run time: 188426 ms |
ClickBench: Total hot run time: 27.4 s |
|
run nonConcurrent |
|
run p0 |
|
run cloud_p0 |
FE Regression Coverage ReportIncrement line coverage |
1 similar comment
FE Regression Coverage ReportIncrement line coverage |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
FE Regression Coverage ReportIncrement line coverage |
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
before, manual snapshot allow user does not set ttl and label like
ADMIN CREATE CLUSTER SNAPSHOT.this pr requires that user must set ttl and label.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)