Skip to content

Conversation

@mymeiyi
Copy link
Contributor

@mymeiyi mymeiyi commented Nov 18, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:
before, manual snapshot allow user does not set ttl and label like ADMIN CREATE CLUSTER SNAPSHOT.
this pr requires that user must set ttl and label.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Nov 18, 2025

run buildall

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 71.43% (5/7) 🎉
Increment coverage report
Complete coverage report

@doris-robot
Copy link

TPC-H: Total hot run time: 34232 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e9d623d58f3b6a98ae72522874983fbd0cf4f234, data reload: false

------ Round 1 ----------------------------------
q1	17605	5113	4932	4932
q2	2001	347	204	204
q3	10232	1316	718	718
q4	10234	928	368	368
q5	7552	2234	2458	2234
q6	185	181	137	137
q7	891	805	621	621
q8	9342	1409	1148	1148
q9	6953	5142	5190	5142
q10	6883	2280	1830	1830
q11	526	302	282	282
q12	382	362	229	229
q13	17800	3682	3061	3061
q14	233	234	222	222
q15	571	513	503	503
q16	1037	1007	945	945
q17	587	878	371	371
q18	8201	7245	7157	7157
q19	1099	967	579	579
q20	359	363	241	241
q21	3880	3188	2323	2323
q22	1062	1043	985	985
Total cold run time: 107615 ms
Total hot run time: 34232 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5220	4978	4949	4949
q2	250	336	241	241
q3	2198	2748	2337	2337
q4	1372	1747	1345	1345
q5	4192	4554	4615	4554
q6	213	177	138	138
q7	2111	1986	1891	1891
q8	2657	2726	2651	2651
q9	7306	7311	7346	7311
q10	3096	3271	2841	2841
q11	616	527	508	508
q12	664	765	648	648
q13	3541	3967	3265	3265
q14	307	303	274	274
q15	557	502	497	497
q16	1102	1132	1060	1060
q17	1173	1579	1393	1393
q18	7866	7625	7499	7499
q19	839	907	1016	907
q20	2001	2090	1922	1922
q21	4920	4448	4300	4300
q22	1058	1049	978	978
Total cold run time: 53259 ms
Total hot run time: 51509 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 188426 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e9d623d58f3b6a98ae72522874983fbd0cf4f234, data reload: false

query1	1033	423	414	414
query2	6567	1698	1677	1677
query3	6748	228	225	225
query4	25992	23607	22589	22589
query5	4872	669	528	528
query6	352	238	232	232
query7	4646	510	310	310
query8	310	254	253	253
query9	8705	2960	2924	2924
query10	517	340	304	304
query11	15864	15012	14989	14989
query12	175	124	118	118
query13	1687	563	449	449
query14	10310	9025	9073	9025
query15	199	188	184	184
query16	7316	665	520	520
query17	1197	770	619	619
query18	1994	434	327	327
query19	207	203	179	179
query20	142	134	125	125
query21	218	134	156	134
query22	4102	3961	4247	3961
query23	34029	33040	33173	33040
query24	8106	2338	2410	2338
query25	635	532	477	477
query26	1240	277	167	167
query27	2746	499	355	355
query28	4426	2261	2226	2226
query29	842	618	495	495
query30	303	223	193	193
query31	877	797	680	680
query32	88	82	83	82
query33	621	391	353	353
query34	790	835	517	517
query35	804	841	758	758
query36	962	1012	906	906
query37	132	121	93	93
query38	3497	3495	3473	3473
query39	1478	1416	1422	1416
query40	225	135	125	125
query41	65	63	60	60
query42	133	124	124	124
query43	505	477	434	434
query44	1296	808	804	804
query45	187	181	181	181
query46	880	1008	635	635
query47	1785	1797	1712	1712
query48	397	426	330	330
query49	755	498	413	413
query50	655	679	425	425
query51	3963	3976	3975	3975
query52	117	118	109	109
query53	262	273	208	208
query54	325	321	314	314
query55	96	93	100	93
query56	363	354	333	333
query57	1180	1186	1114	1114
query58	303	289	293	289
query59	2476	2625	2533	2533
query60	370	375	374	374
query61	198	214	156	156
query62	778	713	654	654
query63	234	204	203	203
query64	4539	1189	906	906
query65	4046	3933	3943	3933
query66	1187	443	364	364
query67	15316	15250	15021	15021
query68	3179	995	661	661
query69	482	348	305	305
query70	1318	1325	1218	1218
query71	411	349	333	333
query72	6219	5227	5242	5227
query73	642	599	380	380
query74	9026	9215	8602	8602
query75	3276	3220	2804	2804
query76	3137	1137	745	745
query77	527	428	356	356
query78	9524	9727	9066	9066
query79	2572	818	620	620
query80	1784	648	570	570
query81	566	264	235	235
query82	409	168	141	141
query83	378	322	252	252
query84	258	113	89	89
query85	931	492	468	468
query86	391	345	301	301
query87	3710	3767	3641	3641
query88	2845	2271	2215	2215
query89	389	336	297	297
query90	1820	240	229	229
query91	167	168	137	137
query92	87	75	76	75
query93	1210	1025	691	691
query94	736	440	338	338
query95	431	348	340	340
query96	491	605	282	282
query97	2900	2950	2861	2861
query98	243	227	219	219
query99	1315	1355	1251	1251
Total cold run time: 268739 ms
Total hot run time: 188426 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 27.4 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e9d623d58f3b6a98ae72522874983fbd0cf4f234, data reload: false

query1	0.05	0.05	0.05
query2	0.10	0.05	0.05
query3	0.26	0.09	0.09
query4	1.61	0.12	0.11
query5	0.27	0.25	0.25
query6	1.17	0.63	0.64
query7	0.03	0.03	0.03
query8	0.05	0.04	0.05
query9	0.58	0.52	0.52
query10	0.58	0.59	0.58
query11	0.16	0.11	0.11
query12	0.15	0.12	0.12
query13	0.63	0.61	0.61
query14	1.02	1.01	0.99
query15	0.86	0.84	0.83
query16	0.39	0.39	0.40
query17	0.99	1.03	1.02
query18	0.22	0.20	0.20
query19	1.93	1.78	1.80
query20	0.01	0.02	0.01
query21	15.44	0.20	0.14
query22	5.04	0.06	0.05
query23	15.66	0.27	0.10
query24	2.68	0.98	0.39
query25	0.08	0.05	0.06
query26	0.14	0.13	0.14
query27	0.07	0.06	0.05
query28	4.02	1.14	0.97
query29	12.62	3.92	3.19
query30	0.28	0.13	0.11
query31	2.81	0.59	0.39
query32	3.23	0.55	0.48
query33	3.02	3.05	3.06
query34	15.81	5.20	4.50
query35	4.60	4.56	4.54
query36	0.66	0.50	0.49
query37	0.10	0.07	0.06
query38	0.07	0.04	0.04
query39	0.04	0.03	0.03
query40	0.17	0.14	0.14
query41	0.08	0.03	0.03
query42	0.04	0.03	0.03
query43	0.04	0.04	0.03
Total cold run time: 97.76 s
Total hot run time: 27.4 s

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Nov 19, 2025

run nonConcurrent

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Nov 19, 2025

run p0

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Nov 19, 2025

run cloud_p0

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 0.00% (0/7) 🎉
Increment coverage report
Complete coverage report

1 similar comment
@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 0.00% (0/7) 🎉
Increment coverage report
Complete coverage report

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 19, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 0.00% (0/7) 🎉
Increment coverage report
Complete coverage report

@dataroaring dataroaring merged commit 68ced0d into apache:master Nov 20, 2025
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. cloud reviewed snapshot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants