Skip to content

branch-3.1:[fix](nereids) Fix aggregate source repeat output is different from child repeat #57840 #58114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: branch-3.1
Choose a base branch
from
Open

branch-3.1:[fix](nereids) Fix aggregate source repeat output is different from child repeat #57840 #58114

wants to merge 2 commits into from
+14 −1

Conversation

@seawinde
Copy link
Contributor

@seawinde seawinde commented Nov 18, 2025

What problem does this PR solve?

commitId: 893a1e9
pr: #57840

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@seawinde
[fix](nereids) Fix aggregate source repeat output is different from c…
aa0457b 
…hild repeat (apache#57840)

if cte def has group sets, after cte inline, the aggregate source repeat
output is different from child repeat
the pr fix this

such query as following
```sql
            with t as (
                select t1.l_partkey, t1.l_suppkey, o_orderdate,
                grouping(t1.l_suppkey),
                grouping(o_orderdate),
                grouping_id(t1.l_partkey, t1.l_suppkey),
                grouping_id(t1.l_partkey, t1.l_suppkey, o_orderdate),
                sum(o_totalprice),
                max(o_totalprice),
                min(o_totalprice),
                count(*),
                count(distinct case when o_shippriority > 1 and o_orderkey IN (1, 3) then o_custkey else null end)
                from (select * from lineitem where l_shipdate = '2023-12-11') t1
                left join orders on t1.l_orderkey = orders.o_orderkey and t1.l_shipdate = o_orderdate
                group by
                GROUPING SETS ((l_shipdate, o_orderdate, l_partkey), (l_partkey, l_suppkey), (l_suppkey), ())
            )
            select t1.l_suppkey, t2.o_orderdate
            from
            t t1
            inner join
            t t2 on t1.l_partkey = t2.l_partkey;
```
@seawinde
fix compile
fda7974
@seawinde seawinde requested a review from morrySnow as a code owner November 18, 2025 08:15
@seawinde
Copy link
Contributor Author

seawinde commented Nov 18, 2025

run buildall

@Thearas
Copy link
Contributor

Thearas commented Nov 18, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 18, 2025

FE UT Coverage Report

Increment line coverage 57.14% (4/7) 🎉
Increment coverage report
Complete coverage report

@seawinde seawinde changed the title [fix](nereids) Fix aggregate source repeat output is different from child repeat #57840 branch-3.1:[fix](nereids) Fix aggregate source repeat output is different from child repeat #57840 Nov 19, 2025
@morrySnow
Copy link
Contributor

morrySnow commented Nov 19, 2025

run buildall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow Awaiting requested review from morrySnow morrySnow is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@seawinde @Thearas @hello-stephen @morrySnow