Skip to content

Conversation

Jibing-Li
Copy link
Contributor

@Jibing-Li Jibing-Li commented Sep 22, 2025

What problem does this PR solve?

Add placeholder literal for prepare stage. So the functions only accept specify input values could check it's placeholder or not, and let the placeholder pass validation check. For example, date_trunc function only accept strings like "year", "month" and so on.

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Jibing-Li Jibing-Li marked this pull request as ready for review September 22, 2025 09:06
@Jibing-Li
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 90.00% (9/10) 🎉
Increment coverage report
Complete coverage report

@Jibing-Li
Copy link
Contributor Author

run performance

@doris-robot
Copy link

TPC-H: Total hot run time: 1516 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9e716be8d777571d4b2566555a340f4765f27d54, data reload: false

------ Round 1 ----------------------------------
q1	6986	27	20	20
q2	566	27	26	26
q3	916	19	15	15
q4	971	18	15	15
q5	2278	16	15	15
q6	222	17	16	16
q7	976	24	21	21
q8	1251	15	13	13
q9	16616	15	13	13
q10	4827	17	15	15
q11	461	22	20	20
q12	317	13	12	12
q13	17637	13	12	12
q14	250	12	10	10
q15	614	12	11	11
q16	997	973	954	954
q17	545	13	12	12
q18	7691	14	12	12
q19	1100	12	11	11
q20	354	386	261	261
q21	3760	21	21	21
q22	1117	12	11	11
Total cold run time: 70452 ms
Total hot run time: 1516 ms

----- Round 2, with runtime_filter_mode=off -----
q1	12	12	11	11
q2	20	19	20	19
q3	11	12	12	12
q4	12	10	10	10
q5	10	9	10	9
q6	11	10	10	10
q7	20	18	17	17
q8	10	10	10	10
q9	10	10	11	10
q10	10	10	10	10
q11	18	19	20	19
q12	11	10	10	10
q13	10	10	9	9
q14	10	11	11	11
q15	11	11	10	10
q16	1084	1092	1031	1031
q17	12	11	10	10
q18	10	10	10	10
q19	10	10	11	10
q20	1864	1954	1836	1836
q21	21	19	18	18
q22	10	9	10	9
Total cold run time: 3197 ms
Total hot run time: 3101 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 2730 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9e716be8d777571d4b2566555a340f4765f27d54, data reload: false

query1	1078	19	11	11
query2	7135	19	16	16
query3	7628	13	11	11
query4	26952	13	11	11
query5	4431	12	11	11
query6	379	11	10	10
query7	5447	13	12	12
query8	353	17	17	17
query9	9231	12	12	12
query10	716	11	11	11
query11	15706	10	12	10
query12	183	11	10	10
query13	1719	10	9	9
query14	11152	15	14	14
query15	440	11	10	10
query16	7506	11	10	10
query17	2171	10	9	9
query18	2924	10	11	10
query19	239	10	9	9
query20	137	11	9	9
query21	224	11	10	10
query22	4056	10	9	9
query23	33789	32	13	13
query24	10761	14	12	12
query25	763	10	9	9
query26	1812	10	9	9
query27	3410	12	10	10
query28	6236	11	10	10
query29	1833	10	10	10
query30	629	11	10	10
query31	1723	11	47	11
query32	117	11	9	9
query33	1309	10	8	8
query34	1623	805	514	514
query35	1032	11	9	9
query36	996	10	9	9
query37	171	10	8	8
query38	3623	9	8	8
query39	1498	736	736	736
query40	316	10	10	10
query41	73	10	9	9
query42	144	11	8	8
query43	500	10	10	10
query44	1327	10	9	9
query45	383	10	9	9
query46	1165	10	9	9
query47	1797	10	10	10
query48	423	9	9	9
query49	1277	10	9	9
query50	751	10	10	10
query51	3963	10	9	9
query52	118	11	10	10
query53	240	11	10	10
query54	755	9	9	9
query55	98	10	9	9
query56	340	11	11	11
query57	1296	9	9	9
query58	362	9	8	8
query59	2625	9	8	8
query60	371	9	9	9
query61	180	9	8	8
query62	855	9	8	8
query63	264	10	9	9
query64	5514	10	9	9
query65	4163	10	9	9
query66	1590	11	10	10
query67	16943	37	9	9
query68	3480	10	11	10
query69	680	10	9	9
query70	1467	11	9	9
query71	477	365	344	344
query72	6787	10	9	9
query73	542	10	8	8
query74	9348	12	11	11
query75	3466	11	11	11
query76	2948	10	9	9
query77	871	12	10	10
query78	9884	11	9	9
query79	1067	10	8	8
query80	687	12	10	10
query81	614	10	9	9
query82	302	11	10	10
query83	321	10	9	9
query84	271	9	9	9
query85	1130	8	8	8
query86	412	8	11	8
query87	3885	10	10	10
query88	2929	13	9	9
query89	392	9	11	9
query90	2366	9	8	8
query91	172	8	8	8
query92	90	11	10	10
query93	1062	9	10	9
query94	809	10	8	8
query95	535	9	9	9
query96	430	11	9	9
query97	3107	10	9	9
query98	230	231	221	221
query99	1489	9	9	9
Total cold run time: 291215 ms
Total hot run time: 2730 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 0.1 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9e716be8d777571d4b2566555a340f4765f27d54, data reload: false

query1	0.07	0.02	0.00
query2	0.11	0.01	0.00
query3	0.27	0.01	0.01
query4	1.75	0.01	0.01
query5	0.28	0.00	0.01
query6	1.64	0.01	0.01
query7	0.05	0.01	0.00
query8	0.06	0.00	0.01
query9	0.64	0.00	0.00
query10	0.60	0.00	0.00
query11	0.18	0.00	0.00
query12	0.16	0.00	0.00
query13	0.63	0.00	0.00
query14	1.06	0.00	0.00
query15	0.89	0.01	0.00
query16	0.40	0.02	0.01
query17	1.08	0.00	0.00
query18	0.23	0.00	0.01
query19	2.30	0.00	0.01
query20	0.02	0.00	0.01
query21	15.93	0.01	0.01
query22	6.73	0.00	0.00
query23	15.78	0.01	0.01
query24	1.46	0.00	0.00
query25	0.20	0.00	0.00
query26	0.16	0.01	0.00
query27	0.11	0.01	0.00
query28	1.33	0.00	0.00
query29	13.18	0.01	0.01
query30	0.30	0.01	0.00
query31	2.30	0.00	0.00
query32	5.93	0.00	0.00
query33	4.33	0.00	0.01
query34	7.43	0.00	0.00
query35	6.16	0.01	0.01
query36	0.67	0.00	0.00
query37	0.11	0.00	0.00
query38	0.09	0.00	0.00
query39	0.04	0.01	0.01
query40	0.19	0.00	0.00
query41	0.10	0.00	0.00
query42	0.06	0.00	0.00
query43	0.05	0.01	0.01
Total cold run time: 95.06 s
Total hot run time: 0.1 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants