Skip to content

branch-3.0: [fix](fe) Using try-with-resource for auto close RemoteFileSystem #49637 #49651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2025

Conversation

github-actions[bot]
Copy link
Contributor

Cherry-picked from #49637

@github-actions github-actions bot requested a review from dataroaring as a code owner March 28, 2025 14:13
@Thearas
Copy link
Contributor

Thearas commented Mar 28, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Mar 28, 2025
@Thearas
Copy link
Contributor

Thearas commented Mar 28, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40030 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit eeb1644f66f44cf346e086c079a6ae10afa56659, data reload: false

------ Round 1 ----------------------------------
q1	17574	6857	6561	6561
q2	2052	165	173	165
q3	10543	1124	1114	1114
q4	10222	708	707	707
q5	7766	2856	2868	2856
q6	220	133	133	133
q7	969	608	603	603
q8	9370	1955	2047	1955
q9	6673	6428	6380	6380
q10	6994	2260	2261	2260
q11	457	267	268	267
q12	414	214	214	214
q13	17785	2964	2995	2964
q14	241	202	217	202
q15	508	461	459	459
q16	651	584	580	580
q17	977	563	597	563
q18	7291	6687	6759	6687
q19	1413	974	1044	974
q20	494	199	203	199
q21	4124	3192	3226	3192
q22	1115	995	1008	995
Total cold run time: 107853 ms
Total hot run time: 40030 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6570	6513	6507	6507
q2	327	228	237	228
q3	2928	2784	2943	2784
q4	2100	1789	1785	1785
q5	5771	5761	5677	5677
q6	204	125	126	125
q7	2262	1791	1802	1791
q8	3319	3524	3556	3524
q9	8846	8829	8925	8829
q10	3574	3552	3536	3536
q11	600	502	475	475
q12	803	613	631	613
q13	5808	3176	3128	3128
q14	309	289	257	257
q15	520	460	455	455
q16	681	624	652	624
q17	1826	1630	1598	1598
q18	8339	7796	7733	7733
q19	3858	1494	1593	1494
q20	2034	1811	1778	1778
q21	5317	5249	5235	5235
q22	1107	1011	1018	1011
Total cold run time: 67103 ms
Total hot run time: 59187 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 190525 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit eeb1644f66f44cf346e086c079a6ae10afa56659, data reload: false

query1	973	373	376	373
query2	6528	2071	2050	2050
query3	6710	227	228	227
query4	33898	23375	23279	23279
query5	4381	455	443	443
query6	280	194	181	181
query7	4641	304	306	304
query8	278	222	217	217
query9	9540	2578	2595	2578
query10	481	278	253	253
query11	18305	15199	15108	15108
query12	145	101	98	98
query13	1631	424	409	409
query14	10159	7078	6659	6659
query15	241	170	173	170
query16	8077	437	505	437
query17	1622	571	594	571
query18	2134	328	318	318
query19	242	161	153	153
query20	114	107	111	107
query21	205	107	102	102
query22	4576	4315	4172	4172
query23	34425	33717	33816	33717
query24	11205	2849	2829	2829
query25	650	385	393	385
query26	1399	166	169	166
query27	2932	346	337	337
query28	7988	2418	2396	2396
query29	904	465	427	427
query30	320	159	176	159
query31	1028	780	821	780
query32	100	58	56	56
query33	782	292	310	292
query34	956	490	506	490
query35	882	707	714	707
query36	1106	936	920	920
query37	135	62	65	62
query38	4089	3862	3943	3862
query39	1476	1407	1416	1407
query40	290	102	103	102
query41	53	49	51	49
query42	113	112	105	105
query43	527	494	477	477
query44	1270	794	800	794
query45	184	164	166	164
query46	1135	721	722	721
query47	1942	1822	1845	1822
query48	462	369	373	369
query49	1181	402	388	388
query50	826	418	414	414
query51	7268	7075	7135	7075
query52	104	91	90	90
query53	257	190	194	190
query54	1159	468	469	468
query55	79	75	79	75
query56	271	250	260	250
query57	1244	1120	1093	1093
query58	250	211	218	211
query59	3067	2923	2770	2770
query60	291	267	268	267
query61	151	136	136	136
query62	882	670	664	664
query63	231	192	192	192
query64	5041	746	762	746
query65	3270	3182	3174	3174
query66	1468	338	330	330
query67	16060	15670	15580	15580
query68	4040	603	590	590
query69	425	276	272	272
query70	1180	1127	1072	1072
query71	342	258	267	258
query72	6417	4175	4119	4119
query73	751	354	350	350
query74	10281	8983	8989	8983
query75	3427	2633	2616	2616
query76	2730	996	1095	996
query77	452	289	273	273
query78	10408	9583	9607	9583
query79	1356	608	593	593
query80	1038	441	430	430
query81	559	238	234	234
query82	912	94	88	88
query83	221	154	153	153
query84	238	84	83	83
query85	1279	323	299	299
query86	363	305	286	286
query87	4342	4384	4262	4262
query88	3464	2416	2358	2358
query89	398	298	298	298
query90	1946	189	198	189
query91	181	149	146	146
query92	63	48	51	48
query93	1096	558	560	558
query94	947	291	305	291
query95	363	261	264	261
query96	598	276	289	276
query97	3355	3143	3209	3143
query98	215	205	200	200
query99	1480	1315	1300	1300
Total cold run time: 299481 ms
Total hot run time: 190525 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.7 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit eeb1644f66f44cf346e086c079a6ae10afa56659, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.04
query3	0.23	0.07	0.07
query4	1.63	0.11	0.10
query5	0.52	0.51	0.50
query6	1.14	0.74	0.72
query7	0.02	0.02	0.01
query8	0.04	0.03	0.04
query9	0.56	0.52	0.50
query10	0.53	0.55	0.58
query11	0.15	0.10	0.10
query12	0.14	0.11	0.11
query13	0.61	0.60	0.59
query14	2.72	2.74	2.74
query15	0.90	0.84	0.83
query16	0.39	0.38	0.37
query17	1.01	1.06	1.06
query18	0.24	0.22	0.21
query19	1.95	1.83	1.97
query20	0.01	0.01	0.02
query21	15.35	0.58	0.59
query22	2.49	2.73	1.06
query23	17.01	0.99	0.91
query24	3.50	0.95	0.13
query25	0.21	0.18	0.04
query26	0.32	0.14	0.14
query27	0.04	0.05	0.04
query28	10.98	0.48	0.49
query29	12.59	3.23	3.27
query30	0.24	0.05	0.06
query31	2.85	0.39	0.39
query32	3.23	0.47	0.46
query33	2.99	2.98	2.99
query34	17.01	4.49	4.53
query35	4.57	4.56	4.57
query36	0.68	0.51	0.47
query37	0.08	0.06	0.06
query38	0.04	0.03	0.04
query39	0.04	0.03	0.02
query40	0.17	0.12	0.13
query41	0.09	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 107.44 s
Total hot run time: 30.7 s

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 02ea353 into branch-3.0 Mar 30, 2025
23 of 24 checks passed
@github-actions github-actions bot deleted the auto-pick-49637-branch-3.0 branch March 30, 2025 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants