Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](nereids)change lag/lead function signature (#40060) #44611

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

liutang123
Copy link
Contributor

pick from master #40060

remove CharType from the signature

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@liutang123
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 48980 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 340a6211d77bd9b36253e23e45d59c3e35ae63f4, data reload: false

------ Round 1 ----------------------------------
q1	17739	4389	4357	4357
q2	2056	165	145	145
q3	10417	1881	1903	1881
q4	10313	1253	1302	1253
q5	8862	3907	3929	3907
q6	233	149	125	125
q7	2013	1593	1611	1593
q8	9310	2728	2706	2706
q9	10138	9829	9711	9711
q10	8636	3548	3519	3519
q11	421	243	256	243
q12	474	298	298	298
q13	18352	3948	4051	3948
q14	354	327	331	327
q15	515	465	460	460
q16	561	468	462	462
q17	1128	955	926	926
q18	7340	6924	6853	6853
q19	1672	1549	1535	1535
q20	532	308	311	308
q21	4416	4104	4031	4031
q22	506	395	392	392
Total cold run time: 115988 ms
Total hot run time: 48980 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4324	4311	4280	4280
q2	326	227	237	227
q3	4191	4111	4097	4097
q4	2754	2732	2744	2732
q5	7253	7112	7089	7089
q6	237	123	121	121
q7	3226	2846	2821	2821
q8	4397	4455	4447	4447
q9	13713	13513	13544	13513
q10	4228	4256	4270	4256
q11	751	682	676	676
q12	1021	851	835	835
q13	7189	3708	3694	3694
q14	451	433	435	433
q15	502	460	454	454
q16	652	567	589	567
q17	3895	3894	3868	3868
q18	8759	8694	8735	8694
q19	1722	1694	1640	1640
q20	2405	2139	2144	2139
q21	8495	8387	8421	8387
q22	1049	945	906	906
Total cold run time: 81540 ms
Total hot run time: 75876 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 211866 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 340a6211d77bd9b36253e23e45d59c3e35ae63f4, data reload: false

query1	925	390	430	390
query2	6565	2256	1912	1912
query3	6918	200	200	200
query4	23325	21549	21494	21494
query5	19738	6463	6532	6463
query6	293	230	232	230
query7	4324	302	308	302
query8	250	257	239	239
query9	3071	2622	2584	2584
query10	467	310	308	308
query11	15726	15073	15336	15073
query12	126	78	74	74
query13	1033	448	449	448
query14	17519	13603	13313	13313
query15	372	218	222	218
query16	6481	286	265	265
query17	1759	937	918	918
query18	897	331	320	320
query19	213	149	151	149
query20	103	98	106	98
query21	192	109	94	94
query22	5191	5115	5024	5024
query23	34121	33482	33469	33469
query24	7899	6300	6313	6300
query25	523	428	438	428
query26	1274	164	167	164
query27	2411	297	296	296
query28	6100	2269	2246	2246
query29	2996	2642	2864	2642
query30	236	166	169	166
query31	986	721	786	721
query32	67	55	60	55
query33	453	260	266	260
query34	862	472	470	470
query35	1161	925	877	877
query36	1268	1206	1316	1206
query37	175	62	61	61
query38	3144	2932	2892	2892
query39	1371	1347	1326	1326
query40	310	95	94	94
query41	41	39	38	38
query42	92	86	92	86
query43	626	708	658	658
query44	1145	707	718	707
query45	247	229	229	229
query46	1234	960	965	960
query47	1835	1665	1656	1656
query48	526	421	410	410
query49	657	379	392	379
query50	872	579	600	579
query51	4729	4668	4634	4634
query52	93	87	83	83
query53	225	185	192	185
query54	2657	2506	2497	2497
query55	100	80	88	80
query56	233	209	209	209
query57	1273	1153	1133	1133
query58	226	211	210	210
query59	3520	3257	3285	3257
query60	225	210	201	201
query61	97	95	96	95
query62	839	554	562	554
query63	201	185	171	171
query64	3512	1593	1554	1554
query65	3657	3553	3558	3553
query66	793	461	448	448
query67	15720	15153	14797	14797
query68	10132	623	626	623
query69	507	268	265	265
query70	1685	1408	1417	1408
query71	418	317	319	317
query72	6870	4788	4794	4788
query73	771	324	319	319
query74	6211	5840	5891	5840
query75	5473	3724	3696	3696
query76	5969	1108	1200	1108
query77	1011	268	271	268
query78	12461	11535	11694	11535
query79	5138	636	647	636
query80	1145	403	388	388
query81	492	237	238	237
query82	1589	99	94	94
query83	173	135	130	130
query84	258	71	72	71
query85	882	316	321	316
query86	334	323	301	301
query87	3250	2990	2981	2981
query88	4496	2291	2305	2291
query89	408	286	290	286
query90	1972	210	211	210
query91	162	140	149	140
query92	65	51	53	51
query93	5403	603	553	553
query94	706	208	205	205
query95	2028	1936	2024	1936
query96	656	327	333	327
query97	6451	6342	6390	6342
query98	219	210	197	197
query99	2820	855	944	855
Total cold run time: 316375 ms
Total hot run time: 211866 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.26 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 340a6211d77bd9b36253e23e45d59c3e35ae63f4, data reload: false

query1	0.02	0.02	0.03
query2	0.06	0.02	0.02
query3	0.25	0.05	0.05
query4	1.79	0.06	0.07
query5	0.54	0.52	0.52
query6	1.31	0.60	0.61
query7	0.02	0.01	0.01
query8	0.03	0.02	0.03
query9	0.54	0.49	0.48
query10	0.55	0.54	0.53
query11	0.12	0.09	0.08
query12	0.13	0.09	0.09
query13	0.62	0.62	0.61
query14	0.78	0.79	0.78
query15	0.78	0.77	0.77
query16	0.39	0.36	0.37
query17	1.00	0.99	1.03
query18	0.24	0.24	0.24
query19	1.93	1.88	1.87
query20	0.01	0.01	0.01
query21	15.45	0.59	0.54
query22	2.05	2.97	1.40
query23	17.24	1.00	0.85
query24	5.48	1.05	0.90
query25	0.35	0.10	0.05
query26	0.63	0.16	0.15
query27	0.04	0.04	0.04
query28	7.68	0.73	0.72
query29	12.60	2.22	2.33
query30	0.58	0.52	0.53
query31	2.81	0.38	0.37
query32	3.36	0.50	0.49
query33	3.05	3.08	3.05
query34	15.28	4.79	4.76
query35	4.84	4.83	4.87
query36	1.06	1.01	1.01
query37	0.06	0.04	0.05
query38	0.03	0.02	0.02
query39	0.02	0.01	0.02
query40	0.16	0.14	0.14
query41	0.06	0.01	0.02
query42	0.02	0.01	0.01
query43	0.02	0.02	0.02
Total cold run time: 103.98 s
Total hot run time: 30.26 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 340a6211d77bd9b36253e23e45d59c3e35ae63f4 with default session variables
Stream load json:         20 seconds loaded 2358488459 Bytes, about 112 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       22.2 seconds inserted 10000000 Rows, about 450K ops/s

@liutang123 liutang123 requested a review from morrySnow November 26, 2024 13:28
@lide-reed lide-reed self-requested a review November 26, 2024 13:32
Copy link
Contributor

@lide-reed lide-reed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 26, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@liutang123 liutang123 merged commit 90da61b into apache:branch-2.0 Nov 27, 2024
22 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. area/nereids kind/test reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants