Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve](http) Save the requested url in http execution error #43855 #44105

Merged
merged 1 commit into from
Nov 18, 2024
Merged

[improve](http) Save the requested url in http execution error #43855 #44105

merged 1 commit into from
Nov 18, 2024
+70 −25

Conversation

w41ter
Copy link
Contributor

@w41ter w41ter commented Nov 18, 2024

cherry pick from #43855

@w41ter
Copy link
Contributor Author

w41ter commented Nov 18, 2024

run buildall

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

github-actions[bot]
github-actions bot reviewed Nov 18, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

be/src/http/http_client.h
@@ -147,7 +147,8 @@ class HttpClient {
size_t on_response_data(const void* data, size_t length);

private:
const char* _to_errmsg(CURLcode code);
const char* _to_errmsg(CURLcode code) const;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: function '_to_errmsg' should be marked [[nodiscard]] [modernize-use-nodiscard]

Suggested change
const char* _to_errmsg(CURLcode code) const;
[[nodiscard]] const char* _to_errmsg(CURLcode code) const;

be/src/http/http_client.h
@@ -147,7 +147,8 @@
size_t on_response_data(const void* data, size_t length);

private:
const char* _to_errmsg(CURLcode code);
const char* _to_errmsg(CURLcode code) const;
const char* _get_url() const;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: function '_get_url' should be marked [[nodiscard]] [modernize-use-nodiscard]

Suggested change
const char* _get_url() const;
[[nodiscard]] const char* _get_url() const;

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.55% (8309/21555)
Line Coverage: 30.25% (68694/227105)
Region Coverage: 29.67% (35373/119213)
Branch Coverage: 25.44% (18191/71508)
Coverage Report: http://coverage.selectdb-in.cc/coverage/51ae64dba89dd17b481f1bcebfaa0baca5708872_51ae64dba89dd17b481f1bcebfaa0baca5708872/report/index.html

@w41ter w41ter merged commit 514a17e into apache:branch-2.0 Nov 18, 2024
20 of 24 checks passed
@w41ter w41ter deleted the pick_43855_to_origin_branch-2.0 branch November 18, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@w41ter @doris-robot