[branch-2.0](binlog) Support drop view binlog (#39781) #43408
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
wyxxxcat
force-pushed
the
pick_39781_add_2_0
branch
from
465d23f to
4386cfd
Compare
wyxxxcat
force-pushed
the
pick_39781_add_2_0
branch
from
4386cfd to
d5b5fc0
Compare
|
run buildall |
w41ter
requested changes
Nov 14, 2024
Comment on lines
+2062
to
+2074
| BackupOlapTableInfo backupTableInfo = jobInfo.backupOlapTableObjects.get(tableName); | ||
| if (tableType != TableType.OLAP && tableType != TableType.ODBC && tableType != TableType.VIEW) { | ||
| continue; | ||
| } | ||
| if (tableType == TableType.OLAP && backupTableInfo != null) { | ||
| // drop the non restored partitions. | ||
| dropNonRestoredPartitions(db, (OlapTable) table, backupTableInfo); | ||
| } else if (isCleanTables) { | ||
| // otherwise drop the entire table. | ||
| LOG.info("drop non restored table {}({}). {}", tableName, tableId, this); | ||
| boolean isView = false; | ||
| boolean isForceDrop = false; // move this table into recyclebin. | ||
| env.getInternalCatalog().dropTableWithoutCheck(db, table, isView, isForceDrop); |
There was a problem hiding this comment.
@wyxxxcat This patch is staled, please update.
| @@ -916,23 +916,26 @@ public void dropTable(DropTableStmt stmt) throws DdlException { | |||
| } | |||
| } | |||
|
|
|||
| dropTableInternal(db, table, stmt.isForceDrop()); | |||
| dropTableInternal(db, table, stmt.isView(), stmt.isForceDrop(), watch, costTimes); | |||
There was a problem hiding this comment.
only pick the necessary parameters.
Comment on lines
+925
to
+928
| watch.stop(); | ||
| costTimes.put("6:total", watch.getTime()); | ||
| LOG.info("finished dropping table: {} from db: {}, is view: {}, is force: {}, cost: {}", | ||
| tableName, dbName, stmt.isView(), stmt.isForceDrop(), costTimes); |
There was a problem hiding this comment.
should merge this conflict manually, eg:
LOG.info("finished dropping table: {} from db: {}, is force: {}, is view: {}", tableName, dbName, stmt.isForceDrop(), stmt.isView());
| @@ -942,7 +945,8 @@ public void dropTableWithoutCheck(Database db, Table table, boolean forceDrop) t | |||
| } | |||
|
|
|||
| // Drop a table, the db lock must hold. | |||
| private void dropTableInternal(Database db, Table table, boolean forceDrop) throws DdlException { | |||
| private void dropTableInternal(Database db, Table table, boolean isView, boolean forceDrop, | |||
| StopWatch watch, Map<String, Long> costTimes) throws DdlException { | |||
There was a problem hiding this comment.
remove StopWatch watch, Map<String, Long> costTimes
|
close in favor #44112 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pick #39781