[Fix-16918][Task] Fix wrong permissions configuration while executing shell #16923
Conversation
BruceWong96
requested review from
caishunfeng,
SbloodyS and
ruanwenjun
as code owners
BruceWong96
changed the title
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/FileUtils.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/dolphinscheduler/server/worker/utils/TaskExecutionContextUtils.java
Outdated
Show resolved
Hide resolved
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/FileUtils.java
Outdated
Show resolved
Hide resolved
|
You should run |
SbloodyS
changed the title
Finished. Thanks. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/FileUtils.java
Fixed
Show fixed
Hide fixed
|
@caishunfeng @EricGao888 PTAL. |
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/FileUtils.java
Outdated
Show resolved
Hide resolved
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/FileUtils.java
Show resolved
Hide resolved
| @@ -289,6 +268,29 @@ | |||
| } | |||
| } | |||
|
|
|||
| public static void createDirectoryWithPermission(@NonNull Path path, | |||
| @NonNull Set<PosixFilePermission> permissions) throws IOException { | |||
| if (path.toFile().exists()) { | |||
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
| Files.createDirectories(path); | ||
| } else { | ||
| Path parent = path.getParent(); | ||
| if (parent != null && !parent.toFile().exists()) { |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
| } | ||
|
|
||
| try { | ||
| Files.createDirectory(path); |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
| Files.createDirectory(path); | ||
| Files.setPosixFilePermissions(path, permissions); | ||
| } catch (FileAlreadyExistsException fileAlreadyExistsException) { | ||
| log.error("The directory: {} already exists", path); |
Check failure
Code scanning / CodeQL
Log Injection High
|
Purpose of the pull request
close #16918
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md