Skip to content

chore: downsize sql_planner_extended logical_plan_optimize sample size to 5 #23659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2010YOUY01 merged 2 commits into from
Jul 18, 2026
Merged

chore: downsize sql_planner_extended logical_plan_optimize sample size to 5 #23659

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6370071
chore: downsize `sql_planner_extended` `logical_plan_bench` sample si…
Jefffrey Jul 17, 2026
a3bfb11
downsize to 5 samples
Jefffrey Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion datafusion/core/benches/sql_planner_extended.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,12 +386,16 @@ fn criterion_benchmark(c: &mut Criterion) {
let df = build_test_data_frame(&baseline_ctx, &rt);
let case_heavy_left_join_df = build_case_heavy_left_join_df(&case_heavy_ctx, &rt);

c.bench_function("logical_plan_optimize", |b| {
// really slow :(
let mut group = c.benchmark_group("sample_size_10");
group.sample_size(10);
group.bench_function("logical_plan_optimize", |b| {
b.iter(|| {
let df_clone = df.clone();
black_box(rt.block_on(async { df_clone.into_optimized_plan().unwrap() }));
})
});
group.finish();

c.bench_function("logical_plan_optimize_hotspot_case_heavy_left_join", |b| {
b.iter(|| {
Expand Down
Loading