Skip to content

refactor(hash-aggr): Migrate the partial aggregation skip optimization to the new hash aggregation impl #22899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2010YOUY01 merged 7 commits into from
Jun 15, 2026
Merged

refactor(hash-aggr): Migrate the partial aggregation skip optimization to the new hash aggregation impl #22899

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
dd9bb3b
cleanup hash aggregate stream
2010YOUY01 Jun 11, 2026
8b6a941
forward port skip partial aggregation optimization
2010YOUY01 Jun 11, 2026
6206fc5
default migration aggr
2010YOUY01 Jun 11, 2026
3125d9a
fix test
2010YOUY01 Jun 11, 2026
f0b2d79
review: move old test to new impl + additional test
2010YOUY01 Jun 11, 2026
2302f6e
review: rename util.rs -> skip_partial.rs
2010YOUY01 Jun 13, 2026
26883b5
review: more comments
2010YOUY01 Jun 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion datafusion/common/src/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,7 +605,7 @@ config_namespace! {
/// will be removed after the migration is finished.
///
/// See <https://github.com/apache/datafusion/issues/22710> for details.
pub enable_migration_aggregate: bool, default = false
pub enable_migration_aggregate: bool, default = true

/// Sets the compression codec used when spilling data to disk.
///
Expand Down
1 change: 1 addition & 0 deletions datafusion/physical-plan/src/aggregates/group_values/metrics.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

use crate::metrics::{ExecutionPlanMetricsSet, MetricBuilder, Time};

#[derive(Clone)]
pub(crate) struct GroupByMetrics {
/// Time spent calculating the group IDs from the evaluated grouping columns.
pub(crate) time_calculating_group_ids: Time,
Expand Down
Loading