Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(ffi): plumb
simplify,expressions,reverse_expr, anddocumentationthroughFFI_WindowUDF#22705New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(ffi): plumb
simplify,expressions,reverse_expr, anddocumentationthroughFFI_WindowUDF#22705Changes from 1 commit
b5fbd1ddcb4320763e559027ea4bf109752ee3962c9a24ce5847a1c48561770ea30a83File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why have a
ForeignExpressionArgs? We aren't implementing a trait, which is where that pattern is needed. This seems like an unnecessary layer. Is it becauseExpressionArgsrequires a borrow and we need an owned struct?If that's the case then I think we should follow the naming convention like
ForeignReturnFieldArgsOwnedbecause these expression arguments are not actually foreign at this point. If you're using an agent and it generated this naming convention due to the FFI skill in our repository, then it would be good to update the skill to reflect the fact that it missed this convention.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're correct it exists because ExpressionArgs<'_> holds borrows, so we need an owned struct to carry the data across the FFI boundary before constructing the borrow-based view. i will rename it to follow the existing naming convention like OwnedExpressionArgs
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.