chore: refactor array fn signatures & add more slt tests #17672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jefffrey
commented
Sep 19, 2025
Comment on lines
-107
to
+97
| List(field) | FixedSizeList(field, _) => match field.data_type() { | ||
| List(field) => match field.data_type() { |
There was a problem hiding this comment.
Removed FixedSizeList since signature should coerce it to List
| vec![ | ||
| TypeSignature::ArraySignature(ArrayFunctionSignature::Array { | ||
| arguments: vec![ArrayFunctionArgument::Array], | ||
| array_coercion: None, |
There was a problem hiding this comment.
No coercion here as the implementation natively supports FixedSizeList
| fn return_type(&self, arg_types: &[DataType]) -> Result<DataType> { | ||
| match &arg_types[0] { | ||
| List(field) | FixedSizeList(field, _) => Ok(List(Arc::clone(field))), | ||
| List(field) => Ok(List(Arc::clone(field))), |
There was a problem hiding this comment.
Same reason as flatten
|
|
||
| # DuckDB: [4] | ||
| # ClickHouse: Null | ||
| # Since they dont have the same result, we just follow Postgres, return error |
There was a problem hiding this comment.
Removed this since the query doesn't seem to error (am I misunderstanding what the comment means 🤔 )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #8249 and #8185
Rationale for this change
Some signature for nested functions are outdated and not using more robust/streamlined type signatures; also add more tests (specifically for
LargeListandFixedSizeListarray types) for nested functions.What changes are included in this PR?
Refactor signatures of nested functions to be more streamlined and robust. Add more SLT tests for nested functions to ensure they work with
LargeListandFixedSizeListtypes. No expected behaviour change for these functions in this PR, just refactoring.Are these changes tested?
Existing SLT tests passed & added more tests.
Are there any user-facing changes?
No