Support FixedSizeList for array_slice via coercion to List #17667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jefffrey
commented
Sep 19, 2025
| ), | ||
| volatility: Volatility::Immutable, | ||
| }, | ||
| signature: Signature::array(Volatility::Immutable), |
There was a problem hiding this comment.
Not related to array_slice, just refactoring to make use of equivalent Signature::array function
Comment on lines
-779
to
+771
| signature: Signature { | ||
| type_signature: TypeSignature::ArraySignature( | ||
| ArrayFunctionSignature::Array { | ||
| arguments: vec![ArrayFunctionArgument::Array], | ||
| array_coercion: Some(ListCoercion::FixedSizedListToList), | ||
| }, | ||
| ), | ||
| volatility: Volatility::Immutable, | ||
| }, | ||
| signature: Signature::array(Volatility::Immutable), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #8249
Rationale for this change
Was checking through array functions and found
array_slicedoesn't handleFixedSizeListarrays. Fix so it does.What changes are included in this PR?
Fix signature so it allows automatic coercion from fixed size list to list
Are these changes tested?
Added SLT tests.
Are there any user-facing changes?
No