(fix): Lag function creates unwanted projection (#17630) #17639
+64
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renato2099
force-pushed
the
renato2099/17630
branch
from
8ee56aa to
f3062f2
Compare
|
Hi @timsaucer , Could you please take a look whenever you have some spare cycles? |
alamb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Window functions end up adding two columns
What changes are included in this PR?
Modified the
with_columnmethod to skip columns added by window functions as their aliased version is added anyway.Are these changes tested?
Added a unit test asserting for the specific number of columns.
Are there any user-facing changes?
No