Revert #15476 to fix the datafusion-examples CI fail #15496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I agree, after finding the root cause, we can restart that PR |
alamb
approved these changes
Mar 30, 2025
|
Since CI is failing without this let's merge it in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
custom_datasourceexample panicked duringRepartitionExecplanning #15493.Rationale for this change
I'm not sure why #15476 caused the CI and other case failures #15493 (comment). However, after reverting it, all the tests pass.
I prefer to revert this commit before we fix this issue.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?