refactor(joins::utils): Replace OnceAsync/OnceFut with tokio's OnceCell #15431
+138
−225
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
I wrote this PR mostly to show that it can be done. Replacing
OnceFut
with aOnceCell
has some advantages though:Future
in the ExecutionPlan, but just the synchronization primitive. In theory this can allow to make the ExecutionPlan implementClone
too.What changes are included in this PR?
SharedResultOnceCell
- A wrapper around tokio'sOnceCell<SharedResult<Arc<T>>>
. Arc's are used all over the place to avoid lifetime issuesAre these changes tested?
This PR should not change the behaviour of the join implementations.
Are there any user-facing changes?
No.