Added tests with are writing into parquet files in memory for issue #… #15325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Mar 21, 2025
| ) | ||
| .unwrap(); | ||
|
|
||
| writer.write(&batch).unwrap(); |
There was a problem hiding this comment.
Thanks @pranavJibhakate !
Would you be willing to add a test that the same data could be read back from the parquet file as well?
There was a problem hiding this comment.
I agree; I think the current code tests the re-exported Parquet functionalities, not touching the DataFusion-related code. Ideally, we should test the end-to-end Parquet reading process.
The process roughly looks like this:
- Create a in-memory object_store, and put the Parquet data you generated into the object_store.
- Register the object_store along with the path to the DataFusion.
- Run a SQL query from the DataFusion side to see if the results can be read back.
A loosely related test can be found here: https://github.com/XiangpengHao/parquet-viewer/blob/main/src/tests.rs#L9
There was a problem hiding this comment.
I filed a ticket to track this work:
|
Thanks again @pranavJibhakate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…15158
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?