Skip to content

feat: implement GroupsAccumulator for count(DISTINCT) aggr #15324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
+353 −168
Draft

feat: implement GroupsAccumulator for count(DISTINCT) aggr #15324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0840207
feat: implement GroupsAccumulator for count(DISTINCT) aggr
waynexia Mar 18, 2025
7c166e6
finalize
waynexia Mar 19, 2025
f5c0935
fix clippy
waynexia Mar 19, 2025
2bd4986
record data type
waynexia Mar 19, 2025
7bc506d
dedicate accumulator
waynexia Mar 25, 2025
86390ef
a new method
waynexia Mar 25, 2025
ca805fb
also for normal accumulator
waynexia Mar 25, 2025
9ecd21f
clean up
waynexia Mar 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion datafusion/functions-aggregate-common/src/aggregate/groups_accumulator/accumulate.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,13 @@
// specific language governing permissions and limitations
// under the License.

//! [`GroupsAccumulator`] helpers: [`NullState`] and [`accumulate_indices`]
//! [`GroupsAccumulator`] helpers: [`NullState`] and [`accumulate_indices`]-like functions.
//!
//! This mod provides various kinds of helper functions to work with [`GroupsAccumulator`],
//! here is a quick summary of the functions provided and their purpose/differences:
//! - [`accumulate`]: Accumulate a single, primitive value per group.
//! - [`accumulate_multiple`]: Accumulate multiple, primitive values per group.
//! - [`accumulate_indices`]: Accumulate indices only (without actual value) per group.
//!
//! [`GroupsAccumulator`]: datafusion_expr_common::groups_accumulator::GroupsAccumulator

Expand Down
Loading
Loading