Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extended tests by restore datafusion-testing submodule #15318

Merged
merged 1 commit into from
Mar 20, 2025

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Mar 19, 2025

Which issue does this PR close?

Rationale for this change

Extended tests are failing on main. Example: https://github.com/apache/datafusion/actions/runs/13955086498/job/39064031622

    Finished `release-nonlto` profile [optimized] target(s) in 11m 58s
     Running bin/sqllogictests.rs (target/release-nonlto/deps/sqllogictests-e83c87031ca01d50)
Error: Execution("Error reading directory \"../../datafusion-testing/data/\": No such file or directory (os error 2)\n\nbacktrace:    0: <unknown>\n   1: <unknown>\n   2: <unknown>\n   3: <unknown>\n   4: <unknown>\n   5: <unknown>\n   6: <unknown>\n   7: <unknown>\n   8: <unknown>\n   9: <unknown>\n  10: <unknown>\n  11: <unknown>\n  12: __libc_start_main\n  13: <unknown>\n")
error: test failed, to rerun pass `-p datafusion-sqllogictest --test sqllogictests`

Caused by:
  process didn't exit successfully: `/__w/datafusion/datafusion/target/release-nonlto/deps/sqllogictests-e83c87031ca01d50 --include-sqlite` (exit status: 1)

This is because we accidentally removed the datafusion-testing submodule in #15263

What changes are included in this PR?

Restore the pin

Are these changes tested?

Are there any user-facing changes?

@alamb alamb marked this pull request as ready for review March 19, 2025 19:54
@ozankabak ozankabak merged commit 97548a2 into apache:main Mar 20, 2025
27 checks passed
@alamb
Copy link
Contributor Author

alamb commented Mar 20, 2025

Thanks @adriangb and @ozankabak

@alamb alamb deleted the alamb/fix_extended_teset branch March 20, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants