Migrate datasource tests to insta

[shruti2522]

Which issue does this PR close?

• related to Migrate datasource tests to insta #15246 .

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

[alamb]

Thanks @shruti2522 !

It looks like there are some CI failures on this one so marking as draft for now

[blaginin]

you should be use to use the workspace version

[shruti2522]

I have migrated all the tests for datasource to insta, except these two, I’m still working on these and will open a separate PR for it.

1. physical_plan::json::tests::test_json_with_repartitioning::case_1_uncompressed : for this one, on using batches_to_string, only one case is failing and on using batches_to_sort_string all of them are failing.

---- datasource::physical_plan::json::tests::test_json_with_repartitioning::case_1_uncompressed stdout ----
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ Snapshot Summary ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Snapshot: json_with_repartitioning
Source: datafusion/core/src/datasource/physical_plan/json.rs:582
────────────────────────────────────────────────────────────────────────────────
Expression: batches_to_string(&res)
────────────────────────────────────────────────────────────────────────────────
-old snapshot
+new results
────────────┬───────────────────────────────────────────────────────────────────
    0     0 │ +-----+------------------+---------------+------+
    1     1 │ | a   | b                | c             | d    |
    2     2 │ +-----+------------------+---------------+------+
          3 │+| 2   | [2.0, , -6.1]    | [false, ]     | text |
          4 │+|     |                  |               |      |
    3     5 │ | 1   | [2.0, 1.3, -6.1] | [false, true] | 4    |
    4     6 │ | -10 | [2.0, 1.3, -6.1] | [true, true]  | 4    |
    5       │-| 2   | [2.0, , -6.1]    | [false, ]     | text |
    6       │-|     |                  |               |      |
    7     7 │ +-----+------------------+---------------+------+
────────────┴───────────────────────────────────────────────────────────────────

3. this one is failing because of LF (\n) and CR (\r) diff

---- datasource::physical_plan::csv::tests::test_create_external_table_with_terminator_with_newlines_in_values stdout ----
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ Snapshot Summary ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Snapshot: create_external_table_with_terminator_with_newlines_in_values
Source: datafusion/core/src/datasource/physical_plan/csv.rs:591
────────────────────────────────────────────────────────────────────────────────
Expression: batches_to_string(&df)
────────────────────────────────────────────────────────────────────────────────
-old snapshot
+new results
────────────┬───────────────────────────────────────────────────────────────────
    0     0 │ +-------+-----------------------------+␊
    1     1 │ | col1  | col2                        |␊
    2     2 │ +-------+-----------------------------+␊
    3       │-| 1     | hello␊
          3 |+| 1     | hello␍
    4     4 │ world                 |␊
    5       │-| 2     | something␊
          5 │+| 2     | something␍
    6     6 │ else              |␊
    7       │-| 3     | ␊
    8       │-many␊
    9       │-lines␊
   10       │-make␊
   11       │-good test␊
          7 │+| 3     | ␍
          8 │+many␍
          9 │+lines␍
         10 │+make␍
         11 │+good test␍
   12    12 │  |␊
   13    13 │ | 4     | unquoted                    |␊
   14    14 │ | value | end                         |␊
   15    15 │ +-------+-----------------------------+
────────────┴───────────────────────────────────────────────────────────────────

cc @blaginin @alamb

[xudong963]

Do we need to keep it?

[blaginin]

and above - https://github.com/apache/datafusion/pull/15258/files#diff-8e2e37a8f04acca01f2ec6045987c6e5a6d22d75260cd53090bba71b0c71daaeR677

[alamb]

Thank you @shruti2522 @blaginin and @xudong963

I took the liberty of pushing a few of @blaginin 's suggestions and merging this branch up from main to get the tests passing

[xudong963]

Thank you all, let's go