-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-Add CodeCov #15256
Open
blaginin
wants to merge
27
commits into
apache:main
Choose a base branch
from
blaginin:chore/add-codecov
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Re-Add CodeCov #15256
+86
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .github/workflows/rust.yml
# Conflicts: # .github/workflows/rust.yml
3 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files🚀 New features to boost your workflow:
|
I got a lot of pushback on code coverage when I brought it up, fyi. Here is a report I had done with a manual run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #15155 (comment)
Rationale for this change
We have quite a lot of code that isn't covered in tests. And it's actually easy to miss covering some case when you submit a big PR
What changes are included in this PR?
Now, when a new PR introduces untested code, a warning message will be posted. Example: here.
Coverage data is aggregated from:
linux-test
linux-test-datafusion-cli
sqllogictest-postgres
macos-aarch64
test-datafusion-pyarrow
Excluded from coverage:
datafusion-examples
— not technically tests.verify-benchmark-results
— IMO we shouldn't rely on them for functionality tests, those should be covered on the unit test leveldoctests
— because they requite nightly rust and I couldn't (yet) make it work in the CI (although will try more)There are ways to make checks even more annoying (e.g. putting ❌ in CI checks). I want to do this later, but first, I want to make sure we're measuring coverage properly and others are okay with it. If that’s the case, we’ll tighten CI checks in future PRs.
Absolute coverage example: https://app.codecov.io/gh/blaginin/datafusion/pull/4/tree
Are there any user-facing changes?
No.