Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-Add CodeCov #15256

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

Re-Add CodeCov #15256

wants to merge 27 commits into from

Conversation

blaginin
Copy link
Contributor

Which issue does this PR close?

Related to #15155 (comment)

Rationale for this change

We have quite a lot of code that isn't covered in tests. And it's actually easy to miss covering some case when you submit a big PR

What changes are included in this PR?

Now, when a new PR introduces untested code, a warning message will be posted. Example: here.

Zen Browser 2025-03-15 21 21 46

Coverage data is aggregated from:

  • linux-test
  • linux-test-datafusion-cli
  • sqllogictest-postgres
  • macos-aarch64
  • test-datafusion-pyarrow

Excluded from coverage:

  • datafusion-examples — not technically tests.
  • verify-benchmark-results — IMO we shouldn't rely on them for functionality tests, those should be covered on the unit test level
  • doctests — because they requite nightly rust and I couldn't (yet) make it work in the CI (although will try more)

There are ways to make checks even more annoying (e.g. putting ❌ in CI checks). I want to do this later, but first, I want to make sure we're measuring coverage properly and others are okay with it. If that’s the case, we’ll tighten CI checks in future PRs.

Absolute coverage example: https://app.codecov.io/gh/blaginin/datafusion/pull/4/tree

Are there any user-facing changes?

No.

@github-actions github-actions bot added development-process Related to development process of DataFusion ffi Changes to the ffi crate labels Mar 15, 2025
@blaginin
Copy link
Contributor Author

blaginin commented Mar 15, 2025

To make this work, we'll need to add CODECOV_TOKEN and add the app to the repo (may already be there since we used it before)

@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Additional details and impacted files
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blaginin blaginin changed the title Reanimate Code Coverage Re-Add CodeCov Mar 17, 2025
@blaginin blaginin marked this pull request as ready for review March 17, 2025 19:15
@Omega359
Copy link
Contributor

I got a lot of pushback on code coverage when I brought it up, fyi. Here is a report I had done with a manual run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development-process Related to development process of DataFusion ffi Changes to the ffi crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants