Skip to content

build: Use "stable" channel #14985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

andygrove
Copy link
Member

@andygrove andygrove commented Mar 3, 2025

Which issue does this PR close?

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@andygrove
Copy link
Member Author

@alamb I am not 100% sure if this is the full fix, but seems to help

@alamb
Copy link
Contributor

alamb commented Mar 3, 2025

I think the reason we moved to putting a version in toolchain.toml is to avoid breakages when the next rust release gets released...

@andygrove
Copy link
Member Author

I think the reason we moved to putting a version in toolchain.toml is to avoid breakages when the next rust release gets released...

We pin the Rust version in the rust-version attribute in the Cargo.toml though.

@andygrove
Copy link
Member Author

Rust release notes: https://github.com/rust-lang/rustup/blob/master/CHANGELOG.md

rustup will no longer automatically install the active toolchain if it is not installed
- To ensure its installation, run rustup toolchain install with no arguments

Copy link
Contributor

@edmondop edmondop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@alamb
Copy link
Contributor

alamb commented Mar 3, 2025

So then I don't think this is the right fix -- instead we should be calling rustup install locally, right?

The idea of putting the toolchain file in the repo was so that we controlled the version of rust useed rather than automatically pick up whatever version of Rust happened to be latest stable

The rationale is described in more detail here:

Let me make an alternate proposal

@alamb
Copy link
Contributor

alamb commented Mar 3, 2025

Here is my alternate proposal

(which is basically to call rustup toolchain install). I am testing it now some more

@andygrove andygrove closed this Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error: toolchain '1.85.0-x86_64-unknown-linux-gnu' is not installed on CI / verification script
3 participants