-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: Add ConfigOptions to ScalarFunctionArgs #13527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Omega359
wants to merge
11
commits into
apache:main
Choose a base branch
from
Omega359:feature/scalar_func_args_session_config
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,541
−401
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
86ca11a
Add SessionConfig reference to ScalarFunctionArgs
Omega359 2506537
Fixed doc.
Omega359 b67e7bf
Merge branch 'main' into feature/scalar_func_args_session_config
Omega359 ffe7d79
Merge remote-tracking branch 'upstream/main' into feature/scalar_func…
Omega359 4f50b01
Updates from merge operation.
Omega359 1325a7e
Merge remote-tracking branch 'upstream/main' into feature/scalar_func…
Omega359 b6d12ee
Merge remote-tracking branch 'upstream/main' into feature/scalar_func…
Omega359 aad3e0d
Updates from main.
Omega359 60cffcb
Merge remote-tracking branch 'upstream/main' into feature/scalar_func…
Omega359 61e4ede
Updates from merge operation.
Omega359 5d0a6a2
Merge remote-tracking branch 'origin/feature/scalar_func_args_session…
Omega359 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,6 +22,7 @@ use std::collections::{BTreeMap, HashMap}; | |
use std::error::Error; | ||
use std::fmt::{self, Display}; | ||
use std::str::FromStr; | ||
use std::sync::{Arc, LazyLock}; | ||
|
||
use crate::error::_config_err; | ||
use crate::parsers::CompressionTypeVariant; | ||
|
@@ -724,7 +725,7 @@ config_namespace! { | |
} | ||
|
||
/// A key value pair, with a corresponding description | ||
#[derive(Debug)] | ||
#[derive(Debug, Hash, PartialEq, Eq)] | ||
pub struct ConfigEntry { | ||
/// A unique string to identify this config value | ||
pub key: String, | ||
|
@@ -777,7 +778,20 @@ impl ConfigField for ConfigOptions { | |
} | ||
} | ||
|
||
static CONFIG_OPTIONS_SINGLETON: LazyLock<Arc<ConfigOptions>> = | ||
LazyLock::new(|| Arc::new(ConfigOptions::default())); | ||
|
||
impl ConfigOptions { | ||
/// this is a static singleton to be used for testing only where the default values are sufficient | ||
pub fn default_singleton() -> &'static ConfigOptions { | ||
CONFIG_OPTIONS_SINGLETON.as_ref() | ||
} | ||
|
||
/// this is a static singleton to be used for testing only where the default values are sufficient | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💯 |
||
pub fn default_singleton_arc() -> &'static Arc<ConfigOptions> { | ||
&CONFIG_OPTIONS_SINGLETON | ||
} | ||
|
||
/// Creates a new [`ConfigOptions`] with default values | ||
pub fn new() -> Self { | ||
Self::default() | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an API change, but I think it is required to thread the config options through as each argument is specific
We could potentially improve the
try_into_physical_plan
API (as a follow on PR) to make it easier to update the API in the future using a trait or something likehttps://github.com/apache/datafusion/blob/e99e02b9b9093ceb0c13a2dd32a2a89beba47930/datafusion/expr/src/expr_schema.rs#L39-L38
So this would look something like