Add support for MS Varbinary(MAX) (#1714) #1715
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Very cool! |
alamb
approved these changes
Feb 7, 2025
There was a problem hiding this comment.
Thanks @TylerBrinks -- this looks good to me. It seems there is a CI failure but the code looks good 👍
Once the CI is fixed I think we can merge it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I'm the maintainer of https://github.com/TylerBrinks/SqlParser-cs, a C# port of this library. I'm finally getting around to submitting my first PR for this library based on an issue raised in the C# project.
This change updates the
Varbinarytype to take aBinaryLengthsimilar toVarcharandNvarcharwhereIntegerLengthandMaxis added to the enum. This replaces the u64 parameter in order to allow bothvarbinary(50)andvarbinary(max)syntas for MS Sql and Generic implementations.