Skip to content

Conversation

@hsiang-c
Copy link
Contributor

@hsiang-c hsiang-c commented Jan 23, 2026

Which issue does this PR close?

Closes #3261

Rationale for this change

Building release JAR fails locally on macOS b/c of

error: failed to run custom build command for `hdfs-sys v0.3.0`

Caused by:
  process didn't exit successfully: `/opt/comet-rm/comet/native/target/release/build/hdfs-sys-28614ad89a41cf9d/build-script-build` (exit status: 1)
  --- stderr
  Error: JavaLocatorError { description: "Java is not installed or not in the system PATH" }
warning: build failed, waiting for other jobs to finish...
make: *** [Makefile:54: core-amd64-libs] Error 101

According to hdfs-sys doc, this crate will link to libjvm.

I can't find Java in the base image: ubuntu:20.04 and after installing current required dependencies.

What changes are included in this PR?

Install default-jdk to the Docker image for build.

How are these changes tested?

After the patch, I can build arm64 / amd64 w/o issues.

@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.15%. Comparing base (f09f8af) to head (e40b801).
⚠️ Report is 884 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3262      +/-   ##
============================================
+ Coverage     56.12%   60.15%   +4.02%     
- Complexity      976     1462     +486     
============================================
  Files           119      175      +56     
  Lines         11743    16070    +4327     
  Branches       2251     2663     +412     
============================================
+ Hits           6591     9667    +3076     
- Misses         4012     5059    +1047     
- Partials       1140     1344     +204     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andygrove
Copy link
Member

@hsiang-c you can merge latest from main to fix the CI failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Building release JARs fails locally on macOS

3 participants