chore: Pass Comet configs to native createPlan
#2543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
changed the title
createPlan
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2543 +/- ##
============================================
+ Coverage 56.12% 58.91% +2.79%
- Complexity 976 1457 +481
============================================
Files 119 147 +28
Lines 11743 13644 +1901
Branches 2251 2369 +118
============================================
+ Hits 6591 8039 +1448
- Misses 4012 4382 +370
- Partials 1140 1223 +83 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
comphead
reviewed
Oct 10, 2025
| memoryLimit, | ||
| memoryLimitPerTask, | ||
| taskAttemptId, | ||
| debug = COMET_DEBUG_ENABLED.get(), |
comphead
reviewed
Oct 10, 2025
| } | ||
|
|
||
| impl SparkConfig for HashMap<String, String> { | ||
| fn get_bool(&self, name: &str) -> bool { |
There was a problem hiding this comment.
perhaps in future work we can generialize this methods using macros
There was a problem hiding this comment.
yes, I was also wondering if we can generate Rust code from CometConf.scala somehow, to make all the configs and defaults available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
These changes are in #2521, but I would like them reviewed and merged with higher priority than #2521.
We were already passing Spark configs to native code, but not actually using them. This PR completes this work and simplifies the
createPlancall because we no longer have to keep adding more arguments as we add more configs.What changes are included in this PR?
Refactoring. No functional changes.
How are these changes tested?
These changes have been manually tested as part of #2521