-
Notifications
You must be signed in to change notification settings - Fork 246
feat: support_decimal_types_bool_cast_native_impl #2490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support_decimal_types_bool_cast_native_impl #2490
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2490 +/- ##
============================================
+ Coverage 56.12% 59.15% +3.02%
- Complexity 976 1450 +474
============================================
Files 119 146 +27
Lines 11743 13659 +1916
Branches 2251 2357 +106
============================================
+ Hits 6591 8080 +1489
- Misses 4012 4357 +345
- Partials 1140 1222 +82 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ef7303d
to
d3aca76
Compare
b8795b0
to
6f66247
Compare
@andygrove , Please take a look whenever you get a chance . Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @coderfender
Thank you @andygrove |
Which issue does this PR close?
Closes #2489
Rationale for this change
Support native cast since we dont have support in arrow / df
What changes are included in this PR?
Cast ops changes in
cast.rs
Update logic on scala side to support decimal -> bool type
Reenable cast tests in
CometCastSuite
How are these changes tested?