Skip to content

Conversation

coderfender
Copy link
Contributor

Which issue does this PR close?

Closes #2489

Rationale for this change

Support native cast since we dont have support in arrow / df

What changes are included in this PR?

Cast ops changes in cast.rs
Update logic on scala side to support decimal -> bool type
Reenable cast tests in CometCastSuite

How are these changes tested?

@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 59.15%. Comparing base (f09f8af) to head (529fc80).
⚠️ Report is 606 commits behind head on main.

Files with missing lines Patch % Lines
...scala/org/apache/comet/expressions/CometCast.scala 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2490      +/-   ##
============================================
+ Coverage     56.12%   59.15%   +3.02%     
- Complexity      976     1450     +474     
============================================
  Files           119      146      +27     
  Lines         11743    13659    +1916     
  Branches       2251     2357     +106     
============================================
+ Hits           6591     8080    +1489     
- Misses         4012     4357     +345     
- Partials       1140     1222      +82     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coderfender coderfender force-pushed the impl_comet_native_decimal_bool_cast branch 2 times, most recently from ef7303d to d3aca76 Compare September 29, 2025 16:03
@coderfender coderfender changed the title feat:support_decimal_types_bool_cast_native_impl feat: support_decimal_types_bool_cast_native_impl Sep 29, 2025
@coderfender coderfender force-pushed the impl_comet_native_decimal_bool_cast branch from b8795b0 to 6f66247 Compare October 12, 2025 07:09
@coderfender
Copy link
Contributor Author

@andygrove , Please take a look whenever you get a chance . Thank you

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @coderfender

@andygrove andygrove merged commit 5ea5863 into apache:main Oct 14, 2025
102 checks passed
@coderfender coderfender deleted the impl_comet_native_decimal_bool_cast branch October 14, 2025 20:58
@coderfender
Copy link
Contributor Author

Thank you @andygrove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support native decimal to boolean cast

5 participants