feat: Make DiskManager max_temp_directory_size configurable
#2479
+22
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2479 +/- ##
============================================
+ Coverage 56.12% 59.03% +2.90%
- Complexity 976 1457 +481
============================================
Files 119 146 +27
Lines 11743 13572 +1829
Branches 2251 2358 +107
============================================
+ Hits 6591 8012 +1421
- Misses 4012 4340 +328
- Partials 1140 1220 +80 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
manuzhang
force-pushed
the
add-maxTempDirectorySize-config
branch
from
14498dd to
f607009
Compare
|
Thanks @manuzhang. Could you merge latest from main to fix the CI issues? |
manuzhang
force-pushed
the
add-maxTempDirectorySize-config
branch
from
f607009 to
1231e45
Compare
manuzhang
force-pushed
the
add-maxTempDirectorySize-config
branch
from
1231e45 to
6271893
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2461 .
Rationale for this change
What changes are included in this PR?
Add a new config
spark.comet.max_temp_directory_sizewith default value 100GB for DiskManagermax_temp_directory_size.How are these changes tested?