Skip to content

Conversation

coderfender
Copy link
Contributor

@coderfender coderfender commented Sep 28, 2025

Which issue does this PR close?

Closes #2049

Rationale for this change

These changes are implemented to support numeric types to Decimal 128 types

What changes are included in this PR?

Implement comet native cast operations to cast integral types to decimals.

How are these changes tested?

  1. Re-enable long and Int -> Decimal128 cast tests
  2. Add more tests to check overflow / ANSI edge cases

@coderfender coderfender force-pushed the impl_spark_compatible_cast branch from d1bb221 to 8c3c187 Compare September 28, 2025 04:08
@coderfender
Copy link
Contributor Author

@andygrove , requesting CI kickoff

@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.92%. Comparing base (f09f8af) to head (63c81eb).
⚠️ Report is 581 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2472      +/-   ##
============================================
+ Coverage     56.12%   58.92%   +2.79%     
- Complexity      976     1457     +481     
============================================
  Files           119      147      +28     
  Lines         11743    13642    +1899     
  Branches       2251     2369     +118     
============================================
+ Hits           6591     8038    +1447     
- Misses         4012     4381     +369     
- Partials       1140     1223      +83     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coderfender coderfender changed the title feat:support_long_decimal_cast_native_support feat:support_integral_decimal_cast_native_support Sep 28, 2025
@coderfender coderfender changed the title feat:support_integral_decimal_cast_native_support feat:support_integral_decimal_cast_native Sep 28, 2025
@coderfender coderfender changed the title feat:support_integral_decimal_cast_native feat:support_integral_decimal_cast_native_impl Sep 28, 2025
@andygrove
Copy link
Member

This is looking good @coderfender. I will review more thoroughly later this week.

@comphead
Copy link
Contributor

comphead commented Oct 1, 2025

Once its done, I'll check it with TPCH

@coderfender
Copy link
Contributor Author

Once its done, I'll check it with TPCH

Thank you

@coderfender
Copy link
Contributor Author

@andygrove the one test which failed is perhaps due to a transient error. Can you please rerun that test only whenever you get a chance ?

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @coderfender

@andygrove andygrove changed the title feat:support_integral_decimal_cast_native_impl feat: Add support for Spark-compatible cast from integral to decimal Oct 9, 2025
@coderfender
Copy link
Contributor Author

coderfender commented Oct 9, 2025

Thank you for the approval @andygrove

@andygrove andygrove merged commit 7148d1c into apache:main Oct 9, 2025
110 of 111 checks passed
@andygrove
Copy link
Member

Once its done, I'll check it with TPCH

@comphead this is now merged

@coderfender
Copy link
Contributor Author

@comphead , I would like to volunteer in helping with the TPCH benchmarks too

@coderfender coderfender deleted the impl_spark_compatible_cast branch October 12, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Spark-compatible cast from integral types to decimal

5 participants