-
Notifications
You must be signed in to change notification settings - Fork 246
feat: Add support for Spark-compatible cast from integral to decimal #2472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for Spark-compatible cast from integral to decimal #2472
Conversation
d1bb221
to
8c3c187
Compare
@andygrove , requesting CI kickoff |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2472 +/- ##
============================================
+ Coverage 56.12% 58.92% +2.79%
- Complexity 976 1457 +481
============================================
Files 119 147 +28
Lines 11743 13642 +1899
Branches 2251 2369 +118
============================================
+ Hits 6591 8038 +1447
- Misses 4012 4381 +369
- Partials 1140 1223 +83 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This is looking good @coderfender. I will review more thoroughly later this week. |
Once its done, I'll check it with TPCH |
Thank you |
@andygrove the one test which failed is perhaps due to a transient error. Can you please rerun that test only whenever you get a chance ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @coderfender
Thank you for the approval @andygrove |
@comphead this is now merged |
@comphead , I would like to volunteer in helping with the TPCH benchmarks too |
Which issue does this PR close?
Closes #2049
Rationale for this change
These changes are implemented to support numeric types to Decimal 128 types
What changes are included in this PR?
Implement comet native cast operations to cast integral types to decimals.
How are these changes tested?