Skip to content

fix: Throws an exception when struct type has duplicate keys #2459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: Throws an exception when struct type has duplicate keys #2459

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion common/src/main/scala/org/apache/spark/sql/comet/util/Utils.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,13 @@ object Utils extends CometTypeShim {
name,
fieldType,
Seq(toArrowField("element", elementType, containsNull, timeZoneId)).asJava)
case StructType(fields) =>
case st @ StructType(fields) =>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have a test case to avoid regression?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have a test case to avoid regression?

Sorry for the late reply, I just got back from the Chinese National Day holiday.

I will try to add a test case later.

if (st.names.toSet.size != fields.length) {
throw new SparkException(
"Duplicated field names in Arrow Struct are not allowed," +
s" got ${st.names.mkString("[", ", ", "]")}.")
}

val fieldType = new FieldType(nullable, ArrowType.Struct.INSTANCE, null)
new Field(
name,
Expand Down
Loading