Skip to content

Conversation

cfmcgrady
Copy link
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

While working on #2425, I encountered an error in checkCometOperators.
As a newcomer to the Comet project, I was unaware that native_comet does not support complex type scanning, and the current error message was unclear and difficult to understand.

This PR improves the error message by adding a fallback reason, making it friendlier to new developers.

How are these changes tested?

the log message before this PR

- ToPrettyString (native_comet, jvm shuffle) *** FAILED *** (2 seconds, 79 milliseconds)
  Expected only Comet native operators, but found Project.
  plan: *(1) Project [toprettystring(c16#1030, Some(America/Los_Angeles)) AS pretty_c16#1220]
  +- *(1) ColumnarToRow
     +- FileScan parquet [c16#1030] Batched: true, DataFilters: [], Format: Parquet, Location: InMemoryFileIndex(1 paths)[file:/Users/fchen/Project/arrow-datafusion-comet/spark/target/tmp/Come..., PartitionFilters: [], PushedFilters: [], ReadSchema: struct<c16:array<boolean>> (CometTestBase.scala:215)

after this PR

- ToPrettyString (native_comet, jvm shuffle) *** FAILED *** (1 second, 788 milliseconds)
  Expected only Comet native operators, but found Project.
  plan: Project
  +- ColumnarToRow
     +-  Scan parquet  [COMET: Unsupported schema StructType(StructField(c16,ArrayType(BooleanType,true),true)) for native_comet] (CometTestBase.scala:215)

@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.49%. Comparing base (f09f8af) to head (08a30e2).
⚠️ Report is 544 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2458      +/-   ##
============================================
+ Coverage     56.12%   58.49%   +2.36%     
- Complexity      976     1440     +464     
============================================
  Files           119      146      +27     
  Lines         11743    13507    +1764     
  Branches       2251     2349      +98     
============================================
+ Hits           6591     7901    +1310     
- Misses         4012     4375     +363     
- Partials       1140     1231      +91     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@wForget wForget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a nice improvement. Thanks @cfmcgrady

@mbutrovich mbutrovich merged commit 87c750d into apache:main Sep 26, 2025
104 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants