Skip to content

Conversation

wForget
Copy link
Member

@wForget wForget commented Sep 23, 2025

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

How are these changes tested?

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2025

Codecov Report

❌ Patch coverage is 46.42857% with 90 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.26%. Comparing base (f09f8af) to head (8fb241b).
⚠️ Report is 544 commits behind head on main.

Files with missing lines Patch % Lines
...n/scala/org/apache/comet/rules/CometExecRule.scala 45.45% 69 Missing and 15 partials ⚠️
.../scala/org/apache/spark/sql/comet/util/Utils.scala 0.00% 5 Missing ⚠️
...n/scala/org/apache/comet/ExtendedExplainInfo.scala 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##               main    #2444       +/-   ##
=============================================
- Coverage     56.12%   42.26%   -13.87%     
- Complexity      976     1120      +144     
=============================================
  Files           119      147       +28     
  Lines         11743    13572     +1829     
  Branches       2251     2357      +106     
=============================================
- Hits           6591     5736      -855     
- Misses         4012     6858     +2846     
+ Partials       1140      978      -162     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wForget wForget mentioned this pull request Sep 24, 2025
@mbutrovich
Copy link
Contributor

So is the high level here to prefer ColumnarToColumnar instead of RowToColumnar? If so, I was looking at improving the performance of ArrowWriter and might have a follow up for this. Current ColumnarToColumnar (which I worked on a year ago so I don't feel bad saying this) is quite naive.

@wForget
Copy link
Member Author

wForget commented Sep 24, 2025

So is the high level here to prefer ColumnarToColumnar instead of RowToColumnar?

Thanks for pointing this out. I’m guessing it might prefer RowToColumnar, since the fallback spark operators may not support columnar. I’ll add some logging to verify it.

@wForget wForget force-pushed the test_spark_to_columnar branch from ce76e9e to 4c7fe64 Compare September 25, 2025 06:43
@wForget wForget force-pushed the test_spark_to_columnar branch from 932ea01 to 851c223 Compare September 26, 2025 13:04
@wForget wForget force-pushed the test_spark_to_columnar branch from 851c223 to 3cd00cc Compare September 26, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants