-
Notifications
You must be signed in to change notification settings - Fork 246
[WIP] feat: Prefer to columnar #2444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2444 +/- ##
=============================================
- Coverage 56.12% 42.26% -13.87%
- Complexity 976 1120 +144
=============================================
Files 119 147 +28
Lines 11743 13572 +1829
Branches 2251 2357 +106
=============================================
- Hits 6591 5736 -855
- Misses 4012 6858 +2846
+ Partials 1140 978 -162 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
So is the high level here to prefer ColumnarToColumnar instead of RowToColumnar? If so, I was looking at improving the performance of ArrowWriter and might have a follow up for this. Current ColumnarToColumnar (which I worked on a year ago so I don't feel bad saying this) is quite naive. |
Thanks for pointing this out. I’m guessing it might prefer |
ce76e9e
to
4c7fe64
Compare
932ea01
to
851c223
Compare
851c223
to
3cd00cc
Compare
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
How are these changes tested?