Skip to content

Conversation

coderfender
Copy link
Contributor

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

How are these changes tested?

@coderfender coderfender changed the title Support integral divide feat:Support ANSI mode integral divide Sep 19, 2025
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 58.50%. Comparing base (f09f8af) to head (ae9bbd7).
⚠️ Report is 544 commits behind head on main.

Files with missing lines Patch % Lines
...main/scala/org/apache/comet/serde/arithmetic.scala 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2421      +/-   ##
============================================
+ Coverage     56.12%   58.50%   +2.38%     
- Complexity      976     1440     +464     
============================================
  Files           119      146      +27     
  Lines         11743    13504    +1761     
  Branches       2251     2349      +98     
============================================
+ Hits           6591     7901    +1310     
- Misses         4012     4373     +361     
- Partials       1140     1230      +90     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coderfender
Copy link
Contributor Author

This will be rebased with main once #2136 is merged to main

@coderfender coderfender force-pushed the support_integral_divide branch from 8cebd01 to 065a822 Compare September 25, 2025 22:49
@coderfender coderfender marked this pull request as ready for review September 25, 2025 22:50
@coderfender
Copy link
Contributor Author

Rebased with main since #2136 is merged . @andygrove

@coderfender
Copy link
Contributor Author

@andygrove please take a look whenever you get a chance . (The failed tests are due to a transient issue)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants