Skip to content

Conversation

andygrove
Copy link
Member

@andygrove andygrove commented Aug 22, 2025

Which issue does this PR close?

N/A

Rationale for this change

This follows on from #2180 which passes the serialized Spark config into native code.

This PR simplifies the JNI API by removing some flags that were being passed in. The native code now gets these flags from the Spark config instead.

What changes are included in this PR?

How are these changes tested?

@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.55%. Comparing base (f09f8af) to head (4837935).
⚠️ Report is 406 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2219      +/-   ##
============================================
+ Coverage     56.12%   58.55%   +2.43%     
- Complexity      976     1284     +308     
============================================
  Files           119      143      +24     
  Lines         11743    13223    +1480     
  Branches       2251     2363     +112     
============================================
+ Hits           6591     7743    +1152     
- Misses         4012     4250     +238     
- Partials       1140     1230      +90     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andygrove that looks nice, just wondering if this is possible to test how native side captures the spark param?

@andygrove
Copy link
Member Author

Thanks @andygrove that looks nice, just wondering if this is possible to test how native side captures the spark param?

Good point. I can add an end-to-end test.

@andygrove andygrove marked this pull request as draft August 25, 2025 20:10
@andygrove
Copy link
Member Author

@comphead I incorporated these changes into #2521

@andygrove andygrove closed this Oct 3, 2025
@andygrove andygrove deleted the native-use-spark-config branch October 3, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants