doc: Add Ballista extensions example to the docs. - #1382
Conversation
LouisBurke
changed the title
milenkovicm
changed the title
milenkovicm
left a comment
milenkovicm
left a comment
There was a problem hiding this comment.
thanks @LouisBurke
just a minor comment regarding links, i think we should remove them
| } | ||
| ``` | ||
|
|
||
| The [custom planner](src/planner/custom_planner.rs) is registered in the session state as follows: |
There was a problem hiding this comment.
this link will be dead, we don't really need it, can we remove it?
|
|
||
| ``` | ||
|
|
||
| This should be all moving parts necessary to extend ballista functionality. Last step would be to configure [scheduler](examples/ballista_scheduler.rs) and [executor](examples/ballista_executor.rs) to use new features. |
There was a problem hiding this comment.
this link will be dead, we don't really need it, can we remove it?
| - [Ballista Extensions Source Code](https://github.com/milenkovicm/ballista_extensions) | ||
| - [Apache Arrow Ballista](https://datafusion.apache.org/ballista/) |
There was a problem hiding this comment.
we do not need this two links as well
milenkovicm
left a comment
milenkovicm
left a comment
There was a problem hiding this comment.
thanks @LouisBurke
I've updated those few small comments i had
|
Hi @milenkovicm , |
|
if you have further changes please do open new PR . |
2 participants
Which issue does this PR close?
Closes #1370.
Rationale for this change
The Ballista docs need detail on how to do extensions.
What changes are included in this PR?
Markdown additions.
Are there any user-facing changes?
More document info, specifically extensions example.