Skip to content

feat: update rust edition to 2024 - #1355

Merged
milenkovicm merged 3 commits into
apache:mainfrom
killzoner:main
Jan 2, 2026
Merged

feat: update rust edition to 2024#1355
milenkovicm merged 3 commits into
apache:mainfrom
killzoner:main

Conversation

@killzoner

@killzoner killzoner commented Dec 30, 2025

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Closes #1271

Revival of #1290
I added pyballista migration too compared to the previous PR

Rationale for this change

Update Rust edition. Now possible since upstream datafusion 51 is targeting a recent enough rust MSRV

What changes are included in this PR?

Are there any user-facing changes?

No

@killzoner
killzoner force-pushed the main branch 2 times, most recently from eafadf0 to 96c9253 Compare December 30, 2025 20:30
@killzoner

killzoner commented Dec 30, 2025

Copy link
Copy Markdown
Contributor Author

I noticed that pyballista is still tracking datafusion 49, not sure this is normal and might be a blocker according to #1290 (comment)

Fixed msrv check which was actually wrong - my bad ! - (pyballista MSRV break was not reported) and added it to the check in CI

@milenkovicm

Copy link
Copy Markdown
Contributor

what if we do not change anything in python directory and leave it as it was? keep msrv and dependencies as they were?

@killzoner

Copy link
Copy Markdown
Contributor Author

Fine by me

@milenkovicm milenkovicm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think other changes are ok, just revert changes to python please

@killzoner

Copy link
Copy Markdown
Contributor Author

i think other changes are ok, just revert changes to python please

This should be good now. Added the cargo resolver upgrade since the previous push

@milenkovicm

Copy link
Copy Markdown
Contributor

Thanks @killzoner

@milenkovicm
milenkovicm merged commit 7cc56ab into apache:main Jan 2, 2026
29 checks passed
@killzoner

Copy link
Copy Markdown
Contributor Author

Thank you for the quick feedbacks!

@milenkovicm

Copy link
Copy Markdown
Contributor

there are two fresh new issues if you're interested @killzoner

@killzoner

killzoner commented Jan 2, 2026

Copy link
Copy Markdown
Contributor Author

there are two fresh new issues if you're interested @killzoner

Sure, happy to take on these

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update rust edition to 2024

2 participants