CURATOR-724. Fix LeaderLatch recover on reconnected and missing leaderPath #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rPath Signed-off-by: tison <[email protected]>
kezhuw
approved these changes
Dec 19, 2024
| // (2) Scale it back. | ||
| // | ||
| // See also https://issues.apache.org/jira/browse/CURATOR-724 | ||
| reset(); |
There was a problem hiding this comment.
BTW, before #430, the leaderLatch calls reset method after reconnection, and reset will whatever create the missing parent path nodes. So I didn't find this issue in the old versions. -- CURATOR-724
Just for sure, so, in case of RECONNECTED, we have no idea what happened to the cluster and getChildren is a conservative option comparing to reset.
There was a problem hiding this comment.
Yeah. Updated add a test.
There was a problem hiding this comment.
Also ensure that the test failed without this fix.
tisonkun
commented
Dec 21, 2024
| } | ||
| getChildren(); |
There was a problem hiding this comment.
Also it doesn't hurt we always call getChildren to check our leadership. It's not reset now anyway.
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.