introduce acc record #5385
Merged
introduce acc record #5385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnewson
force-pushed
the
fabric-update-acc-record
branch
from
2f48127 to
0b10ff4
Compare
rnewson
force-pushed
the
fabric-update-acc-record
branch
from
0b10ff4 to
d3eb273
Compare
janl
approved these changes
Jan 7, 2025
pgj
reviewed
Jan 13, 2025
| rexi_monitor:stop(RexiMon) | ||
| end. | ||
|
|
||
| handle_message({rexi_DOWN, _, {_, NodeRef}, _}, _Worker, Acc0) -> |
There was a problem hiding this comment.
Should not the code still be able to handle messages with the tuple-shaped accumulators? Such messages can arrive during upgrade where the cluster has mixed version of nodes.
There was a problem hiding this comment.
the acc is local, the first clause in handle_message is the message term from other nodes
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor fabric_doc_update to use a record for accumulator, to make #5371 enhancement easier.