added special prefixes for ISINs #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ISINs can have special prefixes accodring to ISIN ISO Standard. Missing präfix: EU, XA, XB, XC, XD
sync fork
Counrtries doesn't exist any more. But ISINs with this ISO Code are still valid (and active).
|
I also added two ISO codes as prefix for valid ISINs |
|
Hello @karlkauc Please try git master and see if this PR is still needed. All current cases should be handled by the class now. |
|
Ping @karlkauc |
|
Already in master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISINs can have special prefixes accodring to ISIN ISO Standard.
Missing prefixes:
EU, XA, XB, XC, XD