Skip to content

Conversation

jkbkupczyk
Copy link
Contributor

@jkbkupczyk jkbkupczyk commented Aug 10, 2025

  • migrated tests to JUnit5

Tests not included in this PR:

  • AbstractFTPParseTest - abstract test class - will be addressed in a separate PR (too many changes in current PR)
  • TelnetClientTest - will be addressed in a separate PR
  • ListingFunctionalTest - requires additional work

Relates to #227 (Work in progress: JUnit 5 migration)

FYI @garydgregory

@garydgregory garydgregory merged commit 6bcb1ea into apache:master Aug 11, 2025
11 checks passed
@garydgregory
Copy link
Member

TY @jkbkupczyk , merged.

garydgregory added a commit that referenced this pull request Aug 11, 2025
@jkbkupczyk
Copy link
Contributor Author

Thanks @garydgregory for a quick review and merge! In case of any errors in tests, please let me know.

@garydgregory
Copy link
Member

I had checked that the same number of tests are executed before and after this PR, so that's good.

@jkbkupczyk jkbkupczyk deleted the junit5_migration branch August 19, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants